Closed
Bug 1366918
Opened 7 years ago
Closed 7 years ago
Remove redundant tests from urlConstruction.js and add tests that can be added to test_UpdateUtils_url.js from urlConstruction.js
Categories
(Toolkit :: Application Update, enhancement)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(2 files)
|
16.36 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
|
1.03 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
There is no need for these redundant tests.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8870211 -
Flags: review?(mhowell)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Pushed to try with a couple of other patches https://treeherder.mozilla.org/#/jobs?repo=try&revision=27763e929b4c08f4603f775696ca943d3f5a114a
|
||
Updated•7 years ago
|
Attachment #8870211 -
Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d2362e9dcb5b Remove redundant tests from urlConstruction.js and add tests that can be added to test_UpdateUtils_url.js from urlConstruction.js. r=mhowell
Pushed by rstrong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/86e9b0b07ecc Followup eslint fix for Bug 1366918. r=me
|
|
Assignee | |
Comment 5•7 years ago
|
||
Also landed. I didn't notice that the try job didn't run eslint. :(
Attachment #8870491 -
Flags: review+
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d2362e9dcb5b https://hg.mozilla.org/mozilla-central/rev/86e9b0b07ecc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•