mozregression OS detection doesn't work under MSYS2 on Windows

RESOLVED FIXED in Firefox 55

Status

Testing
mozregression
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: emorley, Assigned: wlach)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

6 months ago
Using MSYS2 on Windows 10 with Python installed via MSYS2, I get:

$ mozregression --good 2016-06-01
...
 0:00.09 ERROR: mozregression supports linux, mac and windows but your os is reported as 'UNKNOWN'.

Changing this mozinfo line:

> elif system.startswith('MINGW'):
(https://hg.mozilla.org/mozilla-central/file/f9ca97a334296facd2e0ea5582e7f12d0fe70fe4/testing/mozbase/mozinfo/mozinfo/mozinfo.py#l90)

...to this fixes the issue:

> elif system.startswith('MINGW') or system.startswith('MSYS_NT'):

Since:

$ python -c 'import platform; print platform.uname()[0]'
MSYS_NT-10.0
Thanks Ed! I guess I'll take this one.

Steps:

1. Make emorley's change
2. Bump version of mozinfo and push new version to pypi
3. Release new version of mozregression w/ updated dependency
Assignee: nobody → wlachance
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 4

6 months ago
Many thanks!
Attachment #8870484 - Flags: review?(ted) → review?(ahalberstadt)
Attachment #8870485 - Flags: review?(ted) → review?(ahalberstadt)

Comment 5

6 months ago
mozreview-review
Comment on attachment 8870484 [details]
Bug 1366919 - Consider MSYS_NT to equal windows in mozinfo

https://reviewboard.mozilla.org/r/141912/#review149796
Attachment #8870484 - Flags: review?(ahalberstadt) → review+

Comment 6

6 months ago
mozreview-review
Comment on attachment 8870485 [details]
Bug 1366919 - Bump mozinfo version to 0.10

https://reviewboard.mozilla.org/r/141914/#review149798
Attachment #8870485 - Flags: review?(ahalberstadt) → review+

Comment 7

6 months ago
Pushed by wlachance@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88b1189b4fdd
Consider MSYS_NT to equal windows in mozinfo r=ahal
https://hg.mozilla.org/integration/autoland/rev/6ebd3de09d6c
Bump mozinfo version to 0.10 r=ahal

Comment 8

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/88b1189b4fdd
https://hg.mozilla.org/mozilla-central/rev/6ebd3de09d6c
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.