1366930 - Correct error handling in mozilla::MediaShutdownManager::InitStatics

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[JW Wang [:jwwang] [:jw_wang]]

Bug 1362927 is a failed attempt because resetting sInstance in MediaShutdownManager::InitStatics() will cause MediaShutdownManager::Instance().Register() to crash immediately without a chance to handle the error in Register().

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1366930 - Correct error handling in mozilla::MediaShutdownManager::InitStatics.

Resetting sInstance in MediaShutdownManager::InitStatics() will cause
MediaShutdownManager::Instance().Register() to crash immediately without
a chance to handle the error in Register().

Instead, we keep an error code to know whether to bail out in Register().

Review commit: https://reviewboard.mozilla.org/r/141762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141762/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8870293 [details]
Bug 1366930 - Correct error handling in mozilla::MediaShutdownManager::InitStatics.

https://reviewboard.mozilla.org/r/141762/#review146314

Sorry for the late review.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e84f6d9930a2
Correct error handling in mozilla::MediaShutdownManager::InitStatics. r=gerald

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e84f6d9930a2