1366996 - Coverity report: Uninitialized members (UNINIT_CTOR) in nsUrlClassifierInfo

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[Thomas Nguyen (:tnguyen)]

** CID 1409773:  Uninitialized members  (UNINIT_CTOR)
/toolkit/components/url-classifier/nsUrlClassifierInfo.cpp: 12 in nsUrlClassifierPositiveCacheEntry::nsUrlClassifierPositiveCacheEntry()()


________________________________________________________________________________________________________
*** CID 1409773:  Uninitialized members  (UNINIT_CTOR)
/toolkit/components/url-classifier/nsUrlClassifierInfo.cpp: 12 in nsUrlClassifierPositiveCacheEntry::nsUrlClassifierPositiveCacheEntry()()
6
7     NS_IMPL_ISUPPORTS(nsUrlClassifierPositiveCacheEntry,
8                       nsIUrlClassifierPositiveCacheEntry)
9
10     nsUrlClassifierPositiveCacheEntry::nsUrlClassifierPositiveCacheEntry()
11     {
>>>     CID 1409773:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "expirySec" is not initialized in this constructor nor in any functions that it calls.
12     }
13
14     NS_IMETHODIMP
15     nsUrlClassifierPositiveCacheEntry::GetExpiry(int64_t* aExpiry)
16     {
17       if (!aExpiry) {

** CID 1409774:  Uninitialized members  (UNINIT_CTOR)
/toolkit/components/url-classifier/nsUrlClassifierInfo.cpp: 37 in nsUrlClassifierCacheEntry::nsUrlClassifierCacheEntry()()


________________________________________________________________________________________________________
*** CID 1409774:  Uninitialized members  (UNINIT_CTOR)
/toolkit/components/url-classifier/nsUrlClassifierInfo.cpp: 37 in nsUrlClassifierCacheEntry::nsUrlClassifierCacheEntry()()
31
32     NS_IMPL_ISUPPORTS(nsUrlClassifierCacheEntry,
33                       nsIUrlClassifierCacheEntry)
34
35     nsUrlClassifierCacheEntry::nsUrlClassifierCacheEntry()
36     {
>>>     CID 1409774:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "expirySec" is not initialized in this constructor nor in any functions that it calls.
37     }
38
39     NS_IMETHODIMP
40     nsUrlClassifierCacheEntry::GetPrefix(nsACString& aPrefix)
41     {
42       aPrefix = prefix;

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1366996 - Fix uninitialized members in nsUrlClassifierInfo.

This is found by Coverity Scan (CID 1409773, 1409774).

Review commit: https://reviewboard.mozilla.org/r/144356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144356/

Comment 2

[François Marier [:francois]]

Comment on attachment 8872847 [details]
Bug 1366996 - Fix uninitialized members in nsUrlClassifierInfo.

https://reviewboard.mozilla.org/r/144356/#review148158

::: commit-message-fbe0e:3
(Diff revision 1)
> +Bug 1366996 - Fix uninitialized members in nsUrlClassifierInfo. r?francois
> +
> +This is found by Coverity Scan (CID 1409773, 1409774).

"was found"

Comment 3

[Dimi Lee [:dimi]]

Comment on attachment 8872847 [details]
Bug 1366996 - Fix uninitialized members in nsUrlClassifierInfo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/144356/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/849d721f9173
Fix uninitialized members in nsUrlClassifierInfo. r=francois

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/849d721f9173