1367000 - Remove duplicate string in about:url-classifier (locales/en-US/chrome/global/aboutUrlClassifier.dtd)

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement)

Description

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #17)
> (In reply to Ton from comment #16)
> > (In reply to Carsten Book [:Tomcat] from comment #15)
> > > https://hg.mozilla.org/mozilla-central/rev/261fe706dd83
> > > +<!ENTITY aboutUrlClassifier.cacheTitle                  "Cache">
> > 
> > Note that aboutUrlClassifier.cacheTitle was already present in the file so
> > now appears twice.
> 
> We need to get rid quickly of this string, i.e I can't expose strings safely
> to localization tools with a duplicate like this.
> 
> On a side note, can you start looping me in in bugs that land strings for
> this feature? Some of the strings you're landing could benefit from
> localization tools.

Comment 1

[Francesco Lodolo [:flod]]

> On a side note, can you start looping me in in bugs that land strings for
> this feature? Some of the strings you're landing could benefit from
> localization tools.

I meant "localization notes", but I was also mixing about:url-classifier with about:debugging.

Comment 2

[Francesco Lodolo [:flod]]

Actually, unassigning for now.

@François
Can you explain why a group of strings landed in bug 1348253 but are completely unused?
https://hg.mozilla.org/mozilla-central/rev/8ce1a738538e

aboutUrlClassifier.cacheTitle is one of them. It landed as a section title, judging by the screenshots, by it's not used.

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Bug 1367000 - Remove duplicate string ID in aboutUrlClassifier.dtd

Review commit: https://reviewboard.mozilla.org/r/141866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141866/

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8870415 [details]
Bug 1367000 - Remove duplicate string ID in aboutUrlClassifier.dtd

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141866/diff/1-2/

Comment 5

[Francesco Lodolo [:flod]]

OK, I've realized just after sending the first version that this is actually a title (also, Nightly updated in the meantime). The patch only removes the duplicate.

I guess titles for sections were pre-landed, but that was missed in bug 1360480?

Comment 6

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Francesco Lodolo [:flod] from comment #5)
> OK, I've realized just after sending the first version that this is actually
> a title (also, Nightly updated in the meantime). The patch only removes the
> duplicate.
> 
> I guess titles for sections were pre-landed, but that was missed in bug
> 1360480?

Yes, those titles for sections were landed in bug 1348253 and they should be removed since we don't use it now.
I am sorry I just forget to remove them in that bug.

Thanks for fixing this issue, and do you want me to create a bug to remove those unused ones?

Comment 7

[François Marier [:francois]]

Comment on attachment 8870415 [details]
Bug 1367000 - Remove duplicate string ID in aboutUrlClassifier.dtd

https://reviewboard.mozilla.org/r/141866/#review145762

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Dimi Lee[:dimi][:dlee] from comment #6)
> Thanks for fixing this issue, and do you want me to create a bug to remove
> those unused ones?

Yes please, unless you're planning to use them very shortly (like it happened for this one).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9984c908c90c
Remove duplicate string ID in aboutUrlClassifier.dtd r=francois

Comment 10

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Francesco Lodolo [:flod] from comment #8)
> Yes please, unless you're planning to use them very shortly (like it
> happened for this one).

Filed Bug 1367324

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9984c908c90c