Closed
Bug 1367027
Opened 8 years ago
Closed 7 years ago
Signature for java crashes are too accurate
Categories
(Socorro :: General, task)
Socorro
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: calixte, Assigned: willkg)
References
Details
All the crashes returned by the query [1] are the same but since the signature contains the length of the ArrayList then they're all differents.
So we should remove this kind of info (eg length, index) and probably add the first function, before ones in java.*, which is in org.mozilla.*. It could be something like [@ java.lang.ArrayIndexOutOfBoundsException at java.util.ArrayList.get(ArrayList.java) | org.mozilla.gecko.home.activitystream.StreamRecyclerAdapter.onItemClicked(StreamRecyclerAdapter.java)]
[1] https://crash-stats.mozilla.com/search/?release_channel=nightly&signature=%40%22java.lang.ArrayIndexOutOfBoundsException%3A%20length%3D%22%5B0-9%5D%2B%22%3B%20index%3D-%22%5B0-9%5D%2B%22%20at%20java.util.ArrayList.get%28ArrayList.java%29%22&product=FennecAndroid&version=55.0a1&date=%3E%3D2016-11-23T11%3A23%3A40.000Z&date=%3C2017-05-23T11%3A23%3A40.000Z&_sort=-date&_facets=version&_facets=build_id&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports
Comment 1•8 years ago
|
||
(In reply to Calixte Denizet (:calixte) from comment #0)
> So we should remove this kind of info (eg length, index) and probably add
> the first function, before ones in java.*
and probably ones in android.* and dalvik.* as well?
On example crash report for that would be https://crash-stats.mozilla.com/report/index/917a221d-82b6-4264-8880-83e840171227#tab-details.
| Assignee | ||
Comment 2•7 years ago
|
||
I haven't looked into this bug, but I just landed a change that drops the exception message from the signature. The query url in the description doesn't bring anything up, so I can't tell if it helped here or not.
Any idea if it helped? Is there more I should do here?
Flags: needinfo?(cdenizet)
| Reporter | ||
Comment 3•7 years ago
|
||
I updated the query:
https://crash-stats.mozilla.com/search/?signature=%40%22java.lang.ArrayIndexOutOfBoundsException%3A%20length%3D%22%5B0-9%5D%2B%22%3B%20index%3D-%22%5B0-9%5D%2B%22%20at%20java.util.ArrayList.get%28ArrayList.java%29%22&product=FennecAndroid&date=%3E%3D2018-04-08T17%3A51%3A50.000Z&date=%3C2018-10-08T17%3A51%3A50.000Z&_sort=-date&_columns=signature#crash-reports
The signature facet is still showing different signatures for different pairs (length, index).
Flags: needinfo?(cdenizet)
| Assignee | ||
Comment 4•7 years ago
|
||
Awesome! I reprocessed the crash reports in that query and now it shows "no results". So I think we're good here. Marking as FIXED.
Assignee: nobody → willkg
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•