Add support for running other browers from mach wpt.

RESOLVED FIXED in Firefox 55

Status

Testing
web-platform-tests
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: jgraham, Unassigned)

Tracking

Version 3
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
This is helpful for comaparing tests results, and can be based on the upstream runwpt insfrastructure.
Comment hidden (mozreview-request)

Comment 2

11 months ago
mozreview-review
Comment on attachment 8870405 [details]
Bug 1367041 - Add |mach wpt| support for Chrome, Edge and Servo,

https://reviewboard.mozilla.org/r/141858/#review145508

::: .gitignore:93
(Diff revision 1)
>  GPATH
>  
>  # Git clone directory for updating web-platform-tests
>  testing/web-platform/sync/
>  
> +# Third party metadata for web-platform-tests

Should there be a .hgignore version too?

::: .gitignore:94
(Diff revision 1)
>  
>  # Git clone directory for updating web-platform-tests
>  testing/web-platform/sync/
>  
> +# Third party metadata for web-platform-tests
> +testing/web-platform/products/

Should this be reviewed by a build peer?

::: testing/web-platform/README.md:248
(Diff revision 1)
> -   e.g. `~/bin`
> -
> -2. In your gecko source tree activate the virtualenv created by mach,
> -   since this has most dependencies already installed. This is typically
> -   in objdir/_virtualenv and is activated via e.g.
> -
> +
> +By default these browsers run without expectation metadata, but it can
> +be added in the `testing/web-platform/products/<product>`
> +directory. To run with the same metadata as for Firefox (so that
> +differences are reported as unexpected results), pass `--meta
> +testing/web-platform/meta` to the machc command.

typo `machc` should be `mach`
Attachment #8870405 - Flags: review?(dburns) → review+
Comment hidden (mozreview-request)
(Reporter)

Updated

11 months ago
Attachment #8870405 - Flags: review?(ted)

Comment 4

11 months ago
mozreview-review
Comment on attachment 8870405 [details]
Bug 1367041 - Add |mach wpt| support for Chrome, Edge and Servo,

https://reviewboard.mozilla.org/r/141858/#review147804
Attachment #8870405 - Flags: review?(ted) → review+

Comment 5

11 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/448b7c4ed09e
Add |mach wpt| support for Chrome, Edge and Servo, r=AutomatedTester

Comment 7

11 months ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab34e949f80e
Backed out changeset 448b7c4ed09e

Comment 8

11 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64ff9b546c6e
Add |mach wpt| support for Chrome, Edge and Servo, r=AutomatedTester

Comment 10

11 months ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7553df81f14
Backed out changeset 64ff9b546c6e

Comment 11

11 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecb85cc1ee3e
Add |mach wpt| support for Chrome, Edge and Servo, r=AutomatedTester

Comment 12

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ecb85cc1ee3e
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Reporter)

Updated

11 months ago
Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.