Closed Bug 1367051 Opened 8 years ago Closed 8 years ago

Not consistent back button is too white and stands out too much after landing patch from bug #1365195

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Version:
55 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox-esr45 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- verified

People

(Reporter: Virtual, Assigned: dao)

References

Details

(Keywords: nightly-community, regression, ux-consistency, Whiteboard: [fixed by patch from bug #1367712])

Attachments

(2 files)

back button in Mozilla Firefox Nightly 55.0a1 (2017-05-23).png
4.21 KB, image/png
Details
back button in Mozilla Firefox Nightly 55.0a1 (2017-05-22).png
4.26 KB, image/png
Details
STR: 1. Open Mozilla Firefox Nightly 55.0a1 (2017-05-23) 2. Open some website pages to see working back button 3. See that back button is too white and stands out too much compared to other buttons in Mozilla Firefox Nightly 55.0a1 (2017-05-22) "Speedy" Regression window (mozilla-central) Good: https://ftp.mozilla.org/pub/firefox/nightly/2017/05/2017-05-22-03-02-07-mozilla-central/ Bad: https://ftp.mozilla.org/pub/firefox/nightly/2017/05/2017-05-23-03-02-06-mozilla-central/ Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9851fcb0bf4d855c36729d7de19f0fa5c9f69776&tochange=5bc1c758ab57c1885dceab4e7837e58af27b998c Probably caused by: 07facc83000c Nihanth Subramanya — Bug 1365195 - [Photon] Implement new back button appearance. r=dao
Flags: needinfo?(nhnt11)
Severity: major → normal
status-firefox55: affected → ---
Keywords: regressionwindow-wanted
Whiteboard: [photon-visual][triage]
Attachment #8870416 - Attachment description: back button.png → back button in Mozilla Firefox Nightly 55.0a1 (2017-05-23).png
Attachment #8870416 - Attachment filename: back button.png → back button in Mozilla Firefox Nightly 55.0a1 (2017-05-23).png
Has Regression Range: --- → yes
Has STR: --- → yes
Summary: Back button is too white and stands out too much in Mozilla Firefox Nightly 55.0a1 (2017-05-23) → Not consistent back button is too white and stands out too much after landing patch from bug #1365195
Flags: qe-verify?
Priority: -- → P3
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Depends on: 1367712
I think bug 1367712 made the back button stand out a bit less, to the point where I think this is now looking as specified.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(nhnt11)
Resolution: --- → WORKSFORME
Flags: qe-verify?
Priority: P3 → --
Whiteboard: [reserve-photon-visual]
Unfortunately, it's not fixed in all cases, especially when user is using Persona/LightTheme/Appearance. @ Dão Gottwald [::dao] - How about using the same button style on back button like on other buttons, but only when user is using Persona/LightTheme/Appearance, so it will be consistent, not too white and not standing out too much, especially with darker themes.
Flags: needinfo?(dao+bmo)
(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #4) > Unfortunately, it's not fixed in all cases, especially when user is using > Persona/LightTheme/Appearance. This appears to be intentional, see the "Spring Rain" option here: https://people-mozilla.org/~shorlander/projects/photon/Mockups/windows-10.html
Flags: needinfo?(dao+bmo)
OK. Thank you very much for detailed explanation.
Status: RESOLVED → VERIFIED
status-firefox55: --- → verified
Resolution: WORKSFORME → FIXED
Whiteboard: [fixed by patch from bug #1367712]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: