OrangeFactor API validation improvements and cleanup

RESOLVED FIXED

Status

Tree Management
OrangeFactor
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

(Blocks: 1 bug)

Details

(Assignee)

Description

a year ago
There are a number of places where the validation in parameters passed to the API can be improved, to add another defence layer.
(Assignee)

Comment 1

a year ago
I no longer had a working Hg setup so wasn't able to use bzexport or mozreview, so pasting commit links here will have to do (tested locally before landing and then after deploying):

remote:   https://hg.mozilla.org/automation/orangefactor/rev/1019cb6f05d31b132df3283e10c9308c2f3275dd
remote:   https://hg.mozilla.org/automation/orangefactor/rev/c7bc63e780fed18c4790a814f9b23135eb725dd2
remote:   https://hg.mozilla.org/automation/orangefactor/rev/00f9f3c44e32cfae4f3fc12f1cd202f2743fdb53
remote:   https://hg.mozilla.org/automation/orangefactor/rev/98d6754d43f67f927a0bc906aa396548433f739a

[webtools@brasstacks1.dmz.scl3 ~]$ cd ~/apps/orangefactor/src/orangefactor/ && hg pull -uv
pulling from https://hg.mozilla.org/automation/orangefactor/
searching for changes
all local heads known remotely
adding changesets
adding manifests
adding file changes
added 4 changesets with 4 changes to 1 files
resolving manifests
getting server/handlers.py
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
[webtools@brasstacks1.dmz.scl3 orangefactor]$ logout
[root@brasstacks1.dmz.scl3 ~]# monit restart orangefactor
Assignee: nobody → emorley
Group: mozilla-employee-confidential
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Updated

a year ago
Blocks: 1367093
You need to log in before you can comment on or make changes to this bug.