Closed Bug 1367119 Opened 7 years ago Closed 7 years ago

make browser.js:BrowserOpenTab emit a browser-open-tab-start observer notification for perceived performance telemetry

Categories

(Firefox :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: dmosedale, Assigned: dmosedale)

Details

Attachments

(1 file)

ActivityStream wants to be able to gauge perceived performance starting as close to the time as the user takes an action to open a new tab as possible.  This won't capture 100% of tab opens because browser.js, <tabbrowser> and friends are fairly spaghetti-like due in part to their ancient heritage, but it seems it ought to get the vast majority.

Patch forthcoming.
The first try run claimed that there were a bunch of failures (which didn't seem to be true, I could only see one, which was a known intermittent).  Furthermore, it didn't generate any talos data.

So I've fired off another one, and with luck, things will look better there.
Comment on attachment 8870624 [details]
Bug 1367119 - make BrowserOpenTab fire browser-open-newtab-start observer,

https://reviewboard.mozilla.org/r/142072/#review147990
Attachment #8870624 - Flags: review?(edilee) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/159c286ba575
make BrowserOpenTab fire browser-open-newtab-start observer, r=Mardak
https://hg.mozilla.org/mozilla-central/rev/159c286ba575
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Component: Activity Streams: General → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: