Closed Bug 1367123 Opened 3 years ago Closed 2 years ago

in-house image hosting on Reddit.com broken on Firefox 53 & 55

Categories

(Firefox :: Untriaged, defect)

defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: u595893, Unassigned)

References

Details

(Keywords: dataloss, regression)

Attachments

(3 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20100101

Steps to reproduce:

First time poster sorry for mistakes


https://www.reddit.com/r/changelog/comments/4kuk2j/reddit_change_introducing_image_uploading_beta/

https://www.reddit.com/r/announcements/comments/4p5dm9/image_hosting_on_reddit/

Goto reddit.com and login using as it has been setup properly

user: imagehostingreddit
pass: 1-8

goto homepage by clicking on top left or reddit.com and
in a new tab start downloading windows 10 iso(just to reproduce easily the problem & can stop it after testing)

Click/middle on images from reddit domain and open as many as possible like 50 or more.

Two problems happen

vanilla Firefox 55 Today's version(mac/linux 32/64bit)

1: images fail to load on many tabs though the connection is high speed and the download in the background also shows it, imagur is hit miss.

2: The tabs show the url name but awesomebar shows about:blank and tab cannot be loaded or refreshed and is gone from the data storage.

This also happens on various sites and not only reddit which have used for reference others like google accelerated pages(those light pages made for slow/mobiles) when on the move (uber to office and high latency/slow connection)

    Google images
    Facebook pages
    Imgur
    Wikipedia images links
    Twitter images/pages
    Bing images/pages
    Ebay review pics/ urls
    Linkedin
    Pinterest images/pages

These are the other sites where it can be seen if open many tabs quickly
*Try again / Reload page is never shown!!!!!!*

Some one suggested disabling throttling by toggling network.throttle.enable
but no use

Using Firefox 50 without this issue, 53/55 *I hit this problem every time*

Please help, chrome and others have no problem even if they hog cpu/ram
See Also: → 1367131
Not a security bug that needs to stay hidden.
Group: firefox-core-security
Could not reproduce it on latest nightly. I downloaded Ubuntu 16.04 (1.4 GB) in the background, open as many tabs I could during the download and all tabs loaded correctly.
(In reply to Flore Allemandou [:flore] from comment #2)
> Could not reproduce it on latest nightly. I downloaded Ubuntu 16.04 (1.4 GB)
> in the background, open as many tabs I could during the download and all
> tabs loaded correctly.

Keep trying it will eventually show up, it appears randomly and try clearing cache ever time before trying to reproduce

https://i.redd.it/z1xhutlh3czy.jpg

like this was turned into about blank but now opens up now.

https://i.redd. links can show the problem easily, take some time and test for a few days you will see it.

Sorry but that the was this bug is, verified with two friends the used old profiles but did reproduce.
see the related bug also , it has somewhat similar issue
Flags: needinfo?(Flore)
Keywords: dataloss, regression
OS: Unspecified → All
Hardware: Unspecified → All
Just now reproduced in the office but we have a few settings disabled for all users

we use ipv4 connection

network.dns.disableIPv6
network.dns.disablePrefetch
network.predictor.enabled

These are disabled with DNS cache service disabled in windows 10
Attached image data loss.jpg
just captured it , see some pages are loading, some right next tabs also lost data, current one too,
only one tab did not show error but error page to reload
(In reply to :Gijs from comment #1)
> Not a security bug that needs to stay hidden.

sorry thought it's networking related so security bug
I opened 58 tabs in the few minutes it took to download the ubuntu iso (very high speed internet here), all of them were correctly loaded.
So I can't confirm this bug. But it does not mean it does not exist.
Flags: needinfo?(Flore)
(In reply to Flore Allemandou [:flore] from comment #7)
> I opened 58 tabs in the few minutes it took to download the ubuntu iso (very
> high speed internet here), all of them were correctly loaded.
> So I can't confirm this bug. But it does not mean it does not exist.

Please also see Bug 1354796 and the comment towards the bottom.
Flags: needinfo?(Flore)
I have tried to reproduce this issue, but as in Flore's case, I couldn't. Unfortunately, I can't replicate your network settings either, so I'm a bit unsure how to further proceed here . Could you please clarify if you encountered this issue in other environments than your office network: I'd be interested to know if you can reproduce this issue outside your office network (or was the initial report reproduced in another network?)?

Also, if this bug is related to the bug 1354796, which got fixed, maybe you could give this issue another test run, since new version of Nightly 56 is now released.
Flags: needinfo?(shellye5)
(In reply to Adrian Florinescu [:AdrianSV] from comment #9)
> I have tried to reproduce this issue, but as in Flore's case, I couldn't.
> Unfortunately, I can't replicate your network settings either, so I'm a bit
> unsure how to further proceed here . Could you please clarify if you
> encountered this issue in other environments than your office network: I'd
> be interested to know if you can reproduce this issue outside your office
> network (or was the initial report reproduced in another network?)?
> 
> Also, if this bug is related to the bug 1354796, which got fixed, maybe you
> could give this issue another test run, since new version of Nightly 56 is
> now released.

Hi had this in two different variations of network and had reverted to FF51 for the time being.

Will test it out and let you know probably next week.
Flags: needinfo?(shellye5) → needinfo?(adrian.florinescu)
FYI just did a quick testing with FF 52.2(released yesterday)
It has the bug, will test it with others tomorrow or next week.
only browser.sessionstore.max_serialize_back was set to -1 somehow in new profile.

after restarting pages reload fine. but in that state - see jpg no refresh or reload happens via kb or mouse,
attaching session too
Shellye, thanks for logging the bug up. Summing up what I understand after the last comments is that after session restore, some of the tabs from red.it (all or just some?) are not loaded, nor the refresh is working on them. I'm a bit confused at this point what the bug we're trying to nail here is, since it seems to me that in comment 0 we were just opening tabs? Might it be we are talking about several bugs there? If that is the case, can you please identify them separately so we know what we are trying to reproduce?

The latest Firefox released now is Version 54.0.1 Build ID 20170628145605 and in comment 11, latest release version should've been Firefox 53, not version 52. I apologize for taking your time but, at this point I'm really confused by all the details we've discussed so far. 

You might want to use a model like this:

Steps: 
1.
2.
3.

Actual Result:
-input here what is actually happening + screenshots if needed

Expected results
-input here what should've happened
Flags: needinfo?(adrian.florinescu) → needinfo?(shellye5)
On mobile so please ignore the formatting.

This is a combo of two STR's

1 : open red.it image links more than 10-30 in quick succession 

when the image/link fails to load the url bar has the link address but refresh/reload button is disabled no error page or anything, see dataloss attachment reload button is visible but not working and other screenshot has the button disabled/greyed out

pressing enter multiple times in urlbar loads the page sometimes.

NOTE this happens mainly on red.it links and sometimes on other sites too(5%)

AR: Page cannot be reloaded

ER: reload button should work and error page should be shown?

2 : Close firefox and reload the session , now the unloaded tabs when selected load properly and work fine.


3 : Until selected the unloaded tabs have no name or description.

ER: Should show tab labels like in firefox pre 50?

Screenshots + Session restore are the same.

Just use the session restore file and to see issue 3

Screenshots show what happens when the links fail to load in 1

Tested with Firefox 52/53/54

Will test it again if you would want with beta/nightly 55-56.
Flags: needinfo?(shellye5) → needinfo?(adrian.florinescu)
missed:

>in comment 11, latest release version should've been Firefox 53, not version 52.

At work ESR52 is used and personally use 54.0.1

>at this point I'm really confused by all the details we've discussed so far. 


Does the above comment help?
Hi Shellye and sorry for the long wait. QA had different priorities, now back on the triage horse.
I went through this bug again and reading bug 1354796 it appears to me that reproducing this issue too needs particular network settings which I cannot emulate due to our internal security measures. (seems I still cannot reproduce comment 15 steps)

My hunch is that part of this issue is the same problem as in bug 1354796, so that being fixed and uplifted to 52ESR should fix at least part of the problem reported here.

Could you please take a bit of time and redo your test? More particular, I am interested if you can reproduce this issue on:
Firefox Nightly 57
Firefox Beta 56
Firefox ESR 52
Flags: needinfo?(shellye5)
Flags: needinfo?(adrian.florinescu)
Flags: needinfo?(Flore)
(In reply to Adrian Florinescu [:AdrianSV] from comment #17)
> Hi Shellye and sorry for the long wait. QA had different priorities, now
> back on the triage horse.
> I went through this bug again and reading bug 1354796 it appears to me that
> reproducing this issue too needs particular network settings which I cannot
> emulate due to our internal security measures. (seems I still cannot
> reproduce comment 15 steps)
> 
> My hunch is that part of this issue is the same problem as in bug 1354796,
> so that being fixed and uplifted to 52ESR should fix at least part of the
> problem reported here.
> 
> Could you please take a bit of time and redo your test? More particular, I
> am interested if you can reproduce this issue on:
> Firefox Nightly 57
> Firefox Beta 56
> Firefox ESR 52

using FF52 esr and so far just encountered only once since last week,
also using FF57 beta(https://hg.mozilla.org/releases/mozilla-beta/rev/3d2edf73fb90e8f0601bc0b16e79c1c24919db98)
so it seems it's rather fixed or occurs only some odd occasions.
you can mark it fixed(if the bug arises please reopen)
Flags: needinfo?(shellye5) → needinfo?(adrian.florinescu)
Thanks Shellye.
Based on comment 18, marking as WFM for the time being.
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(adrian.florinescu)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.