1367127 - Use an ImageBrush during DrawTargetD2D1::PushLayer instead of a BitmapBrush

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Mason Chang [Inactive] [:mchang]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1359527#c22

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Use ImageBrush instead of BitmapBrush for DrawTargetD2D1::PushLayer

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8870475 [details] [diff] [review]
Use ImageBrush instead of BitmapBrush for DrawTargetD2D1::PushLayer

Review of attachment 8870475 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. Worth having Bas look at it.

Comment 3

[Mason Chang [Inactive] [:mchang]]

Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=b528ff341a0ed870f34460e7dc882067250ff9b5

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 8870475 [details] [diff] [review]
Use ImageBrush instead of BitmapBrush for DrawTargetD2D1::PushLayer

Review of attachment 8870475 [details] [diff] [review]:
-----------------------------------------------------------------

This should be fine unless it regresses performance.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b128837e667
Use an ImageBrush during DrawTargetD2D1::PushLayer instead of a BitmapBrush. r=bas

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0b128837e667