Sidebar splitter should use an OS color

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
a year ago
11 months ago

People

(Reporter: dao, Unassigned)

Tracking

(Blocks: 1 bug, {regression})

Trunk
Firefox 56
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 wontfix, firefox56 fixed, firefox57 verified)

Details

(Whiteboard: [photon-visual][p3] fixed by bug 1367242)

(Reporter)

Description

a year ago
Bug 1355324 hardcoded this to #ccc, which is alright for Mac but not for Windows and Linux where we support different OS themes.
Whiteboard: [photon-structure] → [photon-structure] [triage]
Flags: qe-verify?
Priority: -- → P2
Whiteboard: [photon-structure] [triage] → [photon-structure]

Updated

a year ago
Priority: P2 → P3
Whiteboard: [photon-structure] → [reserve-photon-structure]
(Reporter)

Updated

a year ago
Blocks: 1325171
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox55: --- → affected
Flags: qe-verify? → qe-verify+
Keywords: regression
Priority: P3 → P2
Whiteboard: [reserve-photon-structure] → [photon-visual][p3]
QA Contact: brindusa.tot
(Reporter)

Updated

a year ago
Depends on: 1367242
Reading the [photon-visual] whiteboard, I am guessing this issue seems on simply Nightly for now. This doesn't sound like a blocker for Release 55, right?
Flags: needinfo?(mmucci)
Flags: needinfo?(dao+bmo)

Comment 2

a year ago
(In reply to Hsin-Yi Tsai (55 Regression Engineering support) [:hsinyi] from comment #1)
> Reading the [photon-visual] whiteboard, I am guessing this issue seems on
> simply Nightly for now. This doesn't sound like a blocker for Release 55,
> right?

I don't know about blocker, but this will affect 55. The sidebar code is just shipping, it's not behind prefs/ifdefs. The whiteboard just means that the photon-visual team intends to look at it.
(Reporter)

Comment 3

a year ago
This has been fixed by bug 1367242 for Firefox 56, still affects but doesn't need to block Firefox 55.
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: affected → wontfix
status-firefox56: --- → fixed
Flags: needinfo?(mmucci)
Flags: needinfo?(dao+bmo)
Resolution: --- → FIXED
Whiteboard: [photon-visual][p3] → [photon-visual][p3] fixed by bug 1367242
Target Milestone: --- → Firefox 56
Iteration: --- → 56.1 - Jun 26
Priority: P2 → P1
status-firefox-esr52: --- → unaffected
Depends on: 1377003
No longer depends on: 1377003

Comment 4

11 months ago
Hi Dão, 

What do we need to verify here? 
Also based on the fact that this bug was fixed by bug 1267242, it will be ok to mark it verified? Thanks
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 5

11 months ago
Verify that the sidebar splitter changes its color based on the OS theme. I would check Windows default themes vs. dark and white High Contrast themes, and maybe a few of different Gtk themes on Linux.
Flags: needinfo?(dao+bmo)

Comment 6

11 months ago
I verified this issue on Windows 10 x64 and Ubuntu 16.04 with FF Nightly 57.0a1(2017-08-10) and I can confirm the fact that the sidebar splitter changes its color based on the OS theme. Thanks Dão for help.
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.