Closed Bug 1367149 Opened 4 years ago Closed 3 years ago
Sidebar splitter should use an OS color
Bug 1355324 hardcoded this to #ccc, which is alright for Mac but not for Windows and Linux where we support different OS themes.
Whiteboard: [photon-structure] → [photon-structure] [triage]
Priority: -- → P2
Whiteboard: [photon-structure] [triage] → [photon-structure]
Priority: P2 → P3
Whiteboard: [photon-structure] → [reserve-photon-structure]
Reading the [photon-visual] whiteboard, I am guessing this issue seems on simply Nightly for now. This doesn't sound like a blocker for Release 55, right?
(In reply to Hsin-Yi Tsai (55 Regression Engineering support) [:hsinyi] from comment #1) > Reading the [photon-visual] whiteboard, I am guessing this issue seems on > simply Nightly for now. This doesn't sound like a blocker for Release 55, > right? I don't know about blocker, but this will affect 55. The sidebar code is just shipping, it's not behind prefs/ifdefs. The whiteboard just means that the photon-visual team intends to look at it.
This has been fixed by bug 1367242 for Firefox 56, still affects but doesn't need to block Firefox 55.
Hi Dão, What do we need to verify here? Also based on the fact that this bug was fixed by bug 1267242, it will be ok to mark it verified? Thanks
Verify that the sidebar splitter changes its color based on the OS theme. I would check Windows default themes vs. dark and white High Contrast themes, and maybe a few of different Gtk themes on Linux.
I verified this issue on Windows 10 x64 and Ubuntu 16.04 with FF Nightly 57.0a1(2017-08-10) and I can confirm the fact that the sidebar splitter changes its color based on the OS theme. Thanks Dão for help.
You need to log in before you can comment on or make changes to this bug.