1367164 - Use IdleDispatch for async snow white killer on main thread

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: idle_snow_white.diff

Bug 1311425 will make this stuff work nicer way, but this should be still ok even now.
Note, I'm explicitly not using deadlines here, just move the stuff to start at idle period to keep this simple.
Possible followup bugs can use deadlines, but I'm not sure how useful that would be in this case since if there are lots of objects to delete, we shouldn't postpone that work too much.

In cases there are no idle periods, forget skippable and CC runs will kill snow white objects.

Let's see what tryserver says about this
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc6781600b0c947ffc4b49485844d759d60bfe1d

Comment 1

[Andrew McCreight [:mccr8]]

How is labeling supposed to work with idle callbacks?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

As of now IdleDispatch is nsIThread level concept, not nsIEventTarget.

Comment 3

[Andrew McCreight [:mccr8]]

As discussed in IRC, we need some additional work to make labeling stuff work with idle dispatch. Bill said it would be better to do this now, and fix the idle dispatch stuff later.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d36ee6a04782c8ee4e818790c33f4456b4666185

Maybe try likes this better.
Things brings back the old dispatch-to-current-logic which was there before labeling.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0daf960b8d19
Use IdleDispatch for async snow white killer on main thread, r=mccr8

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0daf960b8d19