Flash SHIELD study: end-of-study pings are very high

RESOLVED FIXED

Status

()

Core
Plug-ins
P1
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
Created attachment 8870518 [details]
2017-05-23-shield-ended-study.png

Chart attached. I expected ~nobody to be sending end-of-study pings for the Flash study, but this isn't the case. There were a peak of 600 people who sent end-of-study pings on 16-May.

There is an expected a fairly low level of user-ended-study pings, so this doesn't appear to be users *choosing* to leave the study. My understanding of this signal is that it's users being automatically finished, which should not be happening until 15-June.
Flags: needinfo?(glind)
Flags: needinfo?(ddurst)
I also expect none.  Looking in to the code reveals this:  

https://github.com/squarewave/shield-study-essential-flash/blob/master/lib/study.js#L12

```
"duration": 14
```

Which seems like Not What You Want.  

Best fix:  roll a new addon with that value set to a Big Number, and a new addon version, and it will deploy via normal update. This will *extend* existing installs, and *new installs*.

For people who have already expired, they are gone :(
Flags: needinfo?(glind)
Flags: needinfo?(ddurst)
(Assignee)

Updated

8 months ago
Assignee: nobody → benjamin
Blocks: 1335232
Priority: -- → P1
(Assignee)

Comment 2

8 months ago
PR merged, waiting on AMO review
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.