1367219 - DisplayItemData destructor does multiple hashtable lookups

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

We have:

  MOZ_RELEASE_ASSERT(sAliveDisplayItemDatas && sAliveDisplayItemDatas->Contains(this));
  sAliveDisplayItemDatas->RemoveEntry(this);

and this gets hit during frame destruction.

Comment 1

[Jet Villegas (inactive)]

To Miko for the fix. Looks like we can combine these checks.

Comment 2

[Miko Mynttinen]

Attachment: Bug 1367219 - Avoid multiple hashtable lookups in DisplayItemData destructor

Review commit: https://reviewboard.mozilla.org/r/146278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146278/

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8874902 [details]
Bug 1367219 - Avoid multiple hashtable lookups in DisplayItemData destructor

https://reviewboard.mozilla.org/r/146278/#review150390

Comment 4

[Miko Mynttinen]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b443817c1e726b3f589e60d23abf18c8b55eb388

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b935696d413
Avoid multiple hashtable lookups in DisplayItemData destructor r=mattwoodrow

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b935696d413