Closed Bug 1367219 Opened 5 years ago Closed 5 years ago

DisplayItemData destructor does multiple hashtable lookups

Categories

(Core :: Layout, enhancement)

53 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bzbarsky, Assigned: miko)

References

Details

(Whiteboard: [qf:p1])

Attachments

(1 file)

We have:

  MOZ_RELEASE_ASSERT(sAliveDisplayItemDatas && sAliveDisplayItemDatas->Contains(this));
  sAliveDisplayItemDatas->RemoveEntry(this);

and this gets hit during frame destruction.
Whiteboard: [qf] → [qf:p1]
To Miko for the fix. Looks like we can combine these checks.
Assignee: nobody → mikokm
Status: NEW → ASSIGNED
Comment on attachment 8874902 [details]
Bug 1367219 - Avoid multiple hashtable lookups in DisplayItemData destructor

https://reviewboard.mozilla.org/r/146278/#review150390
Attachment #8874902 - Flags: review?(matt.woodrow) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9b935696d413
Avoid multiple hashtable lookups in DisplayItemData destructor r=mattwoodrow
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9b935696d413
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.