Closed
Bug 1367219
Opened 7 years ago
Closed 7 years ago
DisplayItemData destructor does multiple hashtable lookups
Categories
(Core :: Layout, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: mikokm)
References
Details
Attachments
(1 file)
We have: MOZ_RELEASE_ASSERT(sAliveDisplayItemDatas && sAliveDisplayItemDatas->Contains(this)); sAliveDisplayItemDatas->RemoveEntry(this); and this gets hit during frame destruction.
|
||
Updated•7 years ago
|
Whiteboard: [qf] → [qf:p1]
|
||
Comment 1•7 years ago
|
||
To Miko for the fix. Looks like we can combine these checks.
Assignee: nobody → mikokm
|
Assignee | |
Updated•7 years ago
|
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874902 [details] Bug 1367219 - Avoid multiple hashtable lookups in DisplayItemData destructor https://reviewboard.mozilla.org/r/146278/#review150390
Attachment #8874902 -
Flags: review?(matt.woodrow) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b443817c1e726b3f589e60d23abf18c8b55eb388
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9b935696d413 Avoid multiple hashtable lookups in DisplayItemData destructor r=mattwoodrow
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9b935696d413
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•2 years ago
|
Performance Impact: --- → P1
Whiteboard: [qf:p1]
You need to log in
before you can comment on or make changes to this bug.
Description
•