1367226 - Remove unused pref: plugins.navigator_hide_disabled_flash

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Darkspirit]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170523100217

Steps to reproduce:

I opened about:config and wanted to see if I can deactivate NPAPI plugins and googled those prefs and also looked on https://dxr.mozilla.org. Then I found this:
https://dxr.mozilla.org/mozilla-central/search?q=plugins.navigator_hide_disabled_flash&redirect=false
Am I correct that this pref is no longer in use and should be removed from Firefox or does the Adobe Flash Plugin check that pref?

Comment 1

[Benjamin Smedberg]

Yes that is correct.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1367226 - Remove unused pref "plugins.navigator_hide_disabled_flash".

Review commit: https://reviewboard.mozilla.org/r/157284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157284/

Comment 3

[Benjamin Smedberg]

Comment on attachment 8886486 [details]
Bug 1367226 - Remove unused pref "plugins.navigator_hide_disabled_flash".

https://reviewboard.mozilla.org/r/157284/#review162904

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b9f81280f19
Remove unused pref "plugins.navigator_hide_disabled_flash". r=bsmedberg

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0b9f81280f19

Comment 6

[Chris Peterson [:cpeterson]]

Comment on attachment 8886486 [details]
Bug 1367226 - Remove unused pref "plugins.navigator_hide_disabled_flash".

Approval Request Comment
[Feature/Bug causing the regression]: No regression
[User impact if declined]: We removed the "plugin hiding" feature in Firefox 55. To avoid user confusion, we should also remove the pref to enable the feature.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Not risky because it is only removing an unused pref.
[String changes made/needed]: No string changes

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8886486 [details]
Bug 1367226 - Remove unused pref "plugins.navigator_hide_disabled_flash".

remove dead pref, beta55+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ecafc69c34da

Comment 9

[Andrei Vaida [:avaida]]

(In reply to Chris Peterson [:cpeterson] from comment #6)
> [Is this code covered by automated tests?]: No
> [Has the fix been verified in Nightly?]: No
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Chris's assessment on manual testing needs.