59 bytes, text/x-review-board-request
4.18 KB, patch
|Details | Diff | Splinter Review|
2.90 KB, patch
|Details | Diff | Splinter Review|
Filed by: rvandermeulen [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=101339461&repo=autoland https://queue.taskcluster.net/v1/task/Yqj9ryXsR3O4NsY-dcE4yA/runs/0/artifacts/public/logs/live_backing.log Permafailing since bug 1364594 landed.
Comment on attachment 8870571 [details] Bug 1367227: Disable Marionette window maximize tests in headless mode; https://reviewboard.mozilla.org/r/142030/#review145684
Attachment #8870571 - Flags: review?(bdahl) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/2b4c8ed50e42 Disable Marionette window maximize tests in headless mode; r=bdahl
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/72ed8fb02c63 Disable Marionette window rect tests in headless mode. r=bdahl
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/93f307b9b328 Fix incorrect syntax. r=me
The oranges are gone now, but let's leave this bug open for the eventual fixing & re-enabling.
Assignee: nobody → bdahl
During MakeFullScreen, headless wasn't triggering a size mode and full screen changed event which caused marionette to hang waiting for a resize event. I tried to match more of the behavior of the linux and windows backend with the new code.
Attachment #8872000 - Flags: review?(jmuizelaar)
As mentioned on IRC, the current code doesn't actually emulate what "View > Enter Full Screen" does and it will cause the browser to immediately try to exit fullscreen mode because it triggers the event on a chrome window and it's expected to be on a content window (follow aBrowser in ). This doesn't seem to be an issue on various platforms because the exit is ignored while the full screen transition is in progress. The new way does was browser.js does .  http://searchfox.org/mozilla-central/rev/a14524a72de6f4ff738a5e784970f0730cea03d8/browser/base/content/browser-fullScreenAndPointerLock.js#429  http://searchfox.org/mozilla-central/rev/a14524a72de6f4ff738a5e784970f0730cea03d8/browser/base/content/browser.js#3229
Attachment #8872004 - Flags: review?(ato)
And a try run (still waiting on MacOS, but looks good elsewhere): https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f02bdaab6bc45545ea9dbe6ed1fdd8282f39bc5
Attachment #8872000 - Flags: review?(jmuizelaar) → review+
Looks like I should have waited on those osx jobs... It appears that some of the resize events on mac come before the fullscreen transition is complete. I've switched it to now use sizemodechange, as that seems like the more reliable way.
Attachment #8872840 - Flags: review?(ato)
Attachment #8872004 - Attachment is obsolete: true
Comment on attachment 8872840 [details] [diff] [review] Part 2 - Trigger fullscreen the same way Firefox does. Review of attachment 8872840 [details] [diff] [review]: ----------------------------------------------------------------- r+, push when confident.
Attachment #8872840 - Flags: review?(ato) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8a78af3f0280 Part 1 - Match headless fullscreen behavior to other widget backends. r=jrmuizel https://hg.mozilla.org/integration/mozilla-inbound/rev/812a3f2737d4 Part 2 - Trigger fullscreen the same way Firefox does. r=ato
Oranges are gone.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
No known fix -> WFM.
Resolution: FIXED → WORKSFORME
You need to log in before you can comment on or make changes to this bug.