1367245 - stylo: StyleSheet::effective_rules recurses into import rules.

Status: RESOLVED DUPLICATE of bug 1357583

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Which means that we'll add @import rules twice, in the case of stylo, where we have the import stylesheet also in the stylesheet list.

I'm not sure if it should change 

I think we just want to not recurse, but that may require Servo changes. I found this while working in bug 1357583.

I think my plan is to make it work moving the StylesheetSet into Stylist, or something like that...

Comment 1

[Bobby Holley (:bholley)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #0)
> Which means that we'll add @import rules twice, in the case of stylo, where
> we have the import stylesheet also in the stylesheet list.
> 
> I'm not sure if it should change 
> 
> I think we just want to not recurse, but that may require Servo changes. I
> found this while working in bug 1357583.

Can we just conditionally compile that recursive behavior for servo builds?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #1)
> (In reply to Emilio Cobos Álvarez [:emilio] from comment #0)
> > Which means that we'll add @import rules twice, in the case of stylo, where
> > we have the import stylesheet also in the stylesheet list.
> > 
> > I'm not sure if it should change 
> > 
> > I think we just want to not recurse, but that may require Servo changes. I
> > found this while working in bug 1357583.
> 
> Can we just conditionally compile that recursive behavior for servo builds?

We can, but I'd rather avoid it since it's a footgun.

Comment 3

[Bobby Holley (:bholley)]

Ok, but how much work is the proper servo-side fix? IIUC this could cause us to do unnecessary work rebuilding the stylist, so if we can't quickly fix servo, I think we should conditionally compile.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I'm fixing this for both in bug 1357583. Turns out import rules aren't in the list, but we were adding them twice for both stylo and servo.