1367261 - Nightly builds downloads the complete update instead of the partial partial update when the update check is done before the time partial build is released

Status: RESOLVED WORKSFORME

(Release Engineering :: Release Automation, defect, P3)

Description

[u595893]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20100101

Steps to reproduce:

like the title says,
usually daily around the partial update is released it downloads partial updates but if the check happens just before say 5 mins before the time partial updates are released, firefox 55 downloads the full builds , for the past week hit this 5 times,

Vanilla profile to verify

Comment 1

[Loic]

Please, don't set the flags if you don't know their roles.

Comment 2

[Robert Strong (they/them - no direct email)]

This isn't a client bug and this has to do with how updates are published on the server side.

Comment 3

[Rail Aliiev [:rail]]

I bet this is a duplicate. Simon may know.

Comment 4

[Simon Fraser [:sfraser] ⌚️GMT]

It sounds like this is another example of the 'publish completes, generate partials in parallel' path we have through the release process. We do have plans to avoid this, mostly when everything has moved to Taskcluster. It will mean that the completes are not published until the partials are also available.

Comment 5

[u601173]

with bug 1349227 getting full pushes twice a day but waiting a few hours and checking results is partial update.
Please can this be fixed soon?

Comment 6

[Mark Galoway]

I am getting full updates too twice daily but don't know if it's bug 1324922 or this.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Simon, you might know what our current state is here ?

Comment 8

[Simon Fraser [:sfraser] ⌚️GMT]

(In reply to Nick Thomas [:nthomas] (UTC+12) from comment #7)
> Simon, you might know what our current state is here ?

I don't know if we can fix this easily without reworking the nightly release graph to not publish until the entire graph has finished work. At the moment it gets updated whenever a component is ready. It will be an improvement to have that change, though.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Based on a few spot checks on diffs at https://aus4-admin.mozilla.org/releases/Firefox-mozilla-central-nightly-latest it looks like we're already submitting all partials & the complete at the same time (for each platform+locale combination). And the taskcluster kind deps are organised (in part) like:
    balrog ---> beetmover-repackage  ---> partials-signing
so bug 1357867 may have resolved this by adding the first dep.

Mark, are you having any problems these days ?

Comment 10

[Mark Galoway]

(In reply to Nick Thomas [:nthomas] (UTC+12) from comment #9)
> Based on a few spot checks on diffs at
> https://aus4-admin.mozilla.org/releases/Firefox-mozilla-central-nightly-
> latest it looks like we're already submitting all partials & the complete at
> the same time (for each platform+locale combination). And the taskcluster
> kind deps are organised (in part) like:
>     balrog ---> beetmover-repackage  ---> partials-signing
> so bug 1357867 may have resolved this by adding the first dep.
> 
> Mark, are you having any problems these days ?

Haven't yet in FF63 cycle.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

OK, lets resolve this WORKSFORME.