1367295 - Make sure we can capture the correct media playing state in MediaPlaybackTest.java

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, enhancement)

Description

[Alastor Wu [:alwu]]

Fork from bug1364028 comment11, sometime we might miss the right time to check the media playing state of tab.

It would be changed after 
- receiving "Tab:MediaPlaybackChange" [1]
- changing state of media control [2]

The best way to check it is still using |waitForCondition()|.

After bug1364202, we use the longer time for waiting, I think we could use it instead of waiting the "Tab:MediaPlaybackChange" event.

[1] https://goo.gl/7WTD8B
[2] https://goo.gl/YtoHoQ

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1367295 - remove waitUntilTabMediaStarted().

After bug1364202, we should always use waitForCondition() to check the tab's state.

If the test file is audible, we could use checkIfMediaPlayingSuccess() because
it would check both "media playing" and "audio playing" states.

If the test file is non-audible, we should use checkTabMediaPlayingState() to
ensure the media started playing successfully.

Review commit: https://reviewboard.mozilla.org/r/142140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142140/

Comment 2

[Alastor Wu [:alwu]]

Comment on attachment 8870674 [details]
Bug 1367295 - remove waitUntilTabMediaStarted().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142140/diff/1-2/

Comment 3

[Alastor Wu [:alwu]]

Comment on attachment 8870674 [details]
Bug 1367295 - remove waitUntilTabMediaStarted().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142140/diff/2-3/

Comment 4

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e836462a2e690c6b1eeee485fc6632e1cc0c232

Comment 5

[Alastor Wu [:alwu]]

Hi, bc,
I couldn't see any log when I running the robocop on autophone in the try sever. [1]
It's almost empty in its raw log, it seems no robocop tests were run?
Thanks!

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e836462a2e690c6b1eeee485fc6632e1cc0c232&selectedJob=101455729

Comment 6

[Bob Clary [:bc] (inactive)]

I'm not sure why but the log doesn't display properly in the logviewer. It is *almost* empty, but not quite. You can see it in the raw log though: https://autophone.s3.amazonaws.com/v1/task/DZJynvJkSzinZOKizWpMtQ/runs/0/artifacts/public/build/eb40ae76-0312-496a-9182-796ebeae1d60-autophone.log

Comment 7

[Bob Clary [:bc] (inactive)]

This is also the case for rca on beta. I'll look into it this morning.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&filter-searchStr=autophone&exclusion_profile=false&group_state=expanded&selectedJob=101334186

Comment 8

[Alastor Wu [:alwu]]

(In reply to Bob Clary [:bc:] from comment #6)
> I'm not sure why but the log doesn't display properly in the logviewer. It
> is *almost* empty, but not quite. You can see it in the raw log though:
> https://autophone.s3.amazonaws.com/v1/task/DZJynvJkSzinZOKizWpMtQ/runs/0/
> artifacts/public/build/eb40ae76-0312-496a-9182-796ebeae1d60-autophone.log

I know that, but it doesn't show which tests were run or not. From following line, it seems no tests were run.

> ========= Finished Run Test (results: 0, elapsed: 259 secs) (at 2017-05-23 23:38:53.234763) =========

(In reply to Bob Clary [:bc:] from comment #7)
> This is also the case for rca on beta. I'll look into it this morning.

Thank you very much!

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8870674 [details]
Bug 1367295 - remove waitUntilTabMediaStarted().

https://reviewboard.mozilla.org/r/142140/#review145908

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c0d4257e254
remove waitUntilTabMediaStarted(). r=sebastian

Comment 11

[Bob Clary [:bc] (inactive)]

My local tests with some additional patches appear to work well:
https://treeherder.allizom.org/logviewer.html#?job_id=95354513&repo=autoland

I'll be landing these later today hopefully and we'll see if the log situation improves. I'll keep an eye on it.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c0d4257e254

Comment 13

[Bob Clary [:bc] (inactive)]

I'm still not seeing the output from the test other than the step markers. I'm not sure what is up, but I'll see if I can figure it out.