Closed Bug 1367310 Opened 7 years ago Closed 7 years ago

stylo: :-moz-locale-dir is not internal pseudo-class

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

Product:
Core
Component:
CSS Parsing and Computation
Version:
53 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: xidorn, Assigned: mbrubeck)

References

Details

Attachments

(2 files)

Bug 1367310 - Make :-moz-locale-dir selector non-internal.
59 bytes, text/x-review-board-request
xidorn
: review+
Details
Bug 1367310 - Update stylo test expectations.
59 bytes, text/x-review-board-request
xidorn
: review+
Details 
In servo/servo#16066, support of :-moz-locale-dir is added in Stylo, but it is added as an internal pseudo-class, so it doesn't pass the mochitest in test_selectors.html.

This is a non-standard pseudo-class, so we may either:
1. support it in stylo as a web-exposed pseudo-class as Gecko is currently doing, or
2. unship this from Gecko and remove corresponding tests

I guess it is probably easier to go with the first option.
Priority: -- → P2
Assignee: nobody → mbrubeck
Comment on attachment 8875381 [details]
Bug 1367310 - Make :-moz-locale-dir selector non-internal.

https://reviewboard.mozilla.org/r/146812/#review151052
Attachment #8875381 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8875382 [details]
Bug 1367310 - Update stylo test expectations.

https://reviewboard.mozilla.org/r/146814/#review151054
Attachment #8875382 - Flags: review?(xidorn+moz) → review+
Pushed by mbrubeck@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce5e886383df
Update stylo test expectations. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/ce5e886383df
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: