Closed Bug 1367318 Opened 5 years ago Closed 5 years ago

trim console filter input

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(firefox55 verified)

VERIFIED FIXED
Firefox 55
Iteration:
55.7 - Jun 12
Tracking Status
firefox55 --- verified

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

(Whiteboard: [console-html])

Attachments

(1 file)

STR:
1. Open the console
2. In jsterm, enter `console.log("foo")`
3. In the filter input, enter ` foo` (note the space)

Expected result:
The "foo" message is displayed (it's what does the old console)

Actual result:
The "foo" message is filtered out. (the evaluation result is still here though, because we never filter them)

The way I encountered this was by selecting and copying the location, which adds a space before the text.
Let's wait for Bug 1363678 to land since it moves a lot of things around
Depends on: 1363678
Priority: -- → P2
Whiteboard: [console-html]
Whiteboard: [console-html] → [console-html] [triage]
Flags: qe-verify+
Priority: P2 → P3
QA Contact: iulia.cristescu
Whiteboard: [console-html] [triage] → [reserve-console-html]
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 8873746 [details]
Bug 1367318 - Trim console filter input.

https://reviewboard.mozilla.org/r/145152/#review149142

I think that the trimming should happen when visible messages are calculated (in messages reducer).
If it affects the state the user can't type a space into the input filter field.
Attachment #8873746 - Flags: review?(odvarko)
Iteration: --- → 55.7 - Jun 12
Whiteboard: [reserve-console-html] → [console-html]
> I think that the trimming should happen when visible messages are calculated (in messages reducer).
> If it affects the state the user can't type a space into the input filter field.

Urgh, right, my bad.
I changed it so we only trim in the search functions.
Comment on attachment 8873746 [details]
Bug 1367318 - Trim console filter input.

https://reviewboard.mozilla.org/r/145152/#review149188

Looks good, thanks Nicolas!

R+ assuming Try is green.

Honza
Attachment #8873746 - Flags: review?(odvarko) → review+
https://hg.mozilla.org/mozilla-central/rev/9ddef50dea79
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Managed to reproduce the issue on 55.0a1 (2017-06-02). I can confirm the initial issue is fixed on 55.0a1 (2017-06-12) using  Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.11.6.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.