1367321 - Update app.update.url.manual & app.update.url.details values for nightly

Status: RESOLVED FIXED

(Firefox :: Menus, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

https://nightly.mozilla.org is now a redirect, just update the url to match what is done for the other products.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1367321 - Update app.update.url.manual & app.update.url.details values for nightly

Review commit: https://reviewboard.mozilla.org/r/142198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142198/

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 8870712 [details]
Bug 1367321 - Update app.update.url.manual & app.update.url.details values for nightly

https://reviewboard.mozilla.org/r/142198/#review145850

Apart from a nit, that looks fine to me

::: browser/branding/nightly/pref/firefox-branding.js:21
(Diff revision 1)
>  // URL user can browse to manually if for some reason all update installation
>  // attempts fail.
> -pref("app.update.url.manual", "https://nightly.mozilla.org");
> +pref("app.update.url.manual", "https://www.mozilla.org/%LOCALE%/firefox/nightly/");
>  // A default value for the "More information about this update" link
>  // supplied in the "An update is available" page of the update wizard.
> -pref("app.update.url.details", "https://nightly.mozilla.org");
> +pref("app.update.url.details", "https://www.mozilla.org/%LOCALE%/firefox/nightly/notes");

For consistency with other urls, I would add a final slash to the url

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8870712 [details]
Bug 1367321 - Update app.update.url.manual & app.update.url.details values for nightly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142198/diff/1-2/

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 8870712 [details]
Bug 1367321 - Update app.update.url.manual & app.update.url.details values for nightly

https://reviewboard.mozilla.org/r/142198/#review145856

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8870712 [details]
Bug 1367321 - Update app.update.url.manual & app.update.url.details values for nightly

https://reviewboard.mozilla.org/r/142198/#review145976

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cabfd08a7a32
Update app.update.url.manual & app.update.url.details values for nightly r=florian,pascalc

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cabfd08a7a32

Comment 8

[Tanvir Rahman]

I have reproduced this bug with Nightly 55.0a1 (2017-05-24) on Windows 10, 64-bit.

The bug's fix is now verified on Nightly 55.0a1

Build ID 	20170612030208
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170614]