Closed Bug 1367322 Opened 2 years ago Closed 2 years ago

Form Autofill preferences should support search function

Categories

(Toolkit :: Form Manager, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: scottwu, Assigned: scottwu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill:M4] [ETA:8/2])

Attachments

(2 files)

Form Autofill preferences should show up when related keywords are typed into the search box.
Whiteboard: [form autofill:MVP] → [form autofill:M4]
Assignee: nobody → scwwu
Whiteboard: [form autofill:M4] → [form autofill:M4] [ETA:8/2]
Status: NEW → ASSIGNED
Comment on attachment 8892356 [details]
Bug 1367322 - Preferences search support for address autofill.

https://reviewboard.mozilla.org/r/163318/#review173350

::: browser/extensions/formautofill/content/manageAddresses.xhtml:22
(Diff revision 3)
>    </fieldset>
>    <div id="controls-container">
>      <button id="remove" disabled="disabled" data-localization="remove"/>
> -    <button id="add" data-localization="add"/>
> +    <!-- Wrapper is used to properly compute the search tooltip position -->
> +    <div>
> +      <button id="add" data-localization="add" data-searchkeywords="addNewDialogTitle, givenName, additionalName, familyName, organization, streetAddress, state, province, city, country, zip, postalCode, email, tel"/>

We don't need to add the `searchkeywords` attribute for the `#add` button. Preferences search doesn't search the elements in the sub-dialogs.

The only thing we need to do for this bug is adding `searchkeywords` attribute for the `savedAddressesBtn` button[1]. So I think we also could remove the above `setSearchKeywords` function.

[1]: http://searchfox.org/mozilla-central/source/browser/extensions/formautofill/FormAutofillPreferences.jsm#77
Attachment #8892356 - Flags: review?(evan) → review-
Comment on attachment 8892356 [details]
Bug 1367322 - Preferences search support for address autofill.

https://reviewboard.mozilla.org/r/163318/#review173350

> We don't need to add the `searchkeywords` attribute for the `#add` button. Preferences search doesn't search the elements in the sub-dialogs.
> 
> The only thing we need to do for this bug is adding `searchkeywords` attribute for the `savedAddressesBtn` button[1]. So I think we also could remove the above `setSearchKeywords` function.
> 
> [1]: http://searchfox.org/mozilla-central/source/browser/extensions/formautofill/FormAutofillPreferences.jsm#77

Sorry it took me a while to get back to you. I've removed the searchkeywords in subdialogs, as well as the method in `FormAutofillUtils`. Thanks for the tips.
Comment on attachment 8892356 [details]
Bug 1367322 - Preferences search support for address autofill.

https://reviewboard.mozilla.org/r/163318/#review184804

Hi Scott,

Could you add searchkeywords attribute for the add button? Then tooltip could show up successfully.
We're almost done here.

Thank you.
Attachment #8892356 - Flags: review?(evan) → review-
Comment on attachment 8907458 [details]
Bug 1367322 - Preferences search support for credit card autofill.

https://reviewboard.mozilla.org/r/179138/#review184806

Hi Scott,

Could you add searchkeywords attribute for the add button? Then tooltip could show up successfully.

Thank you.
Attachment #8907458 - Flags: review?(evan) → review-
Comment on attachment 8907458 [details]
Bug 1367322 - Preferences search support for credit card autofill.

https://reviewboard.mozilla.org/r/179138/#review184806

Thanks for the feedback. I've added the searchkeywords attributes back to the add buttons.
Comment on attachment 8892356 [details]
Bug 1367322 - Preferences search support for address autofill.

https://reviewboard.mozilla.org/r/163318/#review185312

Looks good to me. Thank you.
Attachment #8892356 - Flags: review?(evan) → review+
Comment on attachment 8907458 [details]
Bug 1367322 - Preferences search support for credit card autofill.

https://reviewboard.mozilla.org/r/179138/#review185314

Looks good to me. Thank you.
Attachment #8907458 - Flags: review?(evan) → review+
Comment on attachment 8892356 [details]
Bug 1367322 - Preferences search support for address autofill.

https://reviewboard.mozilla.org/r/163318/#review185382
Attachment #8892356 - Flags: review?(lchang) → review+
Comment on attachment 8907458 [details]
Bug 1367322 - Preferences search support for credit card autofill.

https://reviewboard.mozilla.org/r/179138/#review185384
Attachment #8907458 - Flags: review?(lchang) → review+
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef45a78e74f2
Preferences search support for address autofill. r=evanxd,lchang
https://hg.mozilla.org/integration/autoland/rev/5e160c22afe7
Preferences search support for credit card autofill. r=evanxd,lchang
https://hg.mozilla.org/mozilla-central/rev/ef45a78e74f2
https://hg.mozilla.org/mozilla-central/rev/5e160c22afe7
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.