Filter mocha test is broken

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Console
P1
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Tracking

unspecified
Firefox 55
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [console-html])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
STR: `cd devtools/client/webconsole && npm test`

Error:

1) FilterBar component: displays filter bar when button is clicked:
     Error: Expected false to be true
      at assert (node_modules/expect/lib/assert.js:29:9)
      at Expectation.toBe (node_modules/expect/lib/Expectation.js:66:28)
      at Context.<anonymous> (new-console-output/test/components/filter-bar.test.js:82:58
(Assignee)

Updated

9 months ago
Priority: -- → P2
Whiteboard: [console-html]

Updated

9 months ago
Flags: qe-verify?
Whiteboard: [console-html] → [console-html] [triage]

Updated

9 months ago
Flags: qe-verify? → qe-verify-
Whiteboard: [console-html] [triage] → [console-html]
Comment hidden (mozreview-request)

Comment 2

9 months ago
mozreview-review
Comment on attachment 8872283 [details]
Bug 1367395 - Fix mocha filter component test.

https://reviewboard.mozilla.org/r/143784/#review147584

Looks reasonable, thanks for fixing the test!

Btw. I am still seeing one failure coming from `filters.test.js`
Perhaps it could be also fixed as part of this bug (also related to filters, maybe to source maps?)

Honza


1) Filtering Text filter matches stacktrace functionName:

      Error: Expected 0 to equal 1
      + expected - actual

      -0
      +1

      at assert (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\expect\lib\assert.js:29:9)
      at Expectation.toEqual (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\expect\lib\Expectation.js:81:30)
      at Context.<anonymous> (C:/src/mozilla.org/mozilla-central/devtools/client/webconsole/new-console-output/test/store/filters.test.js:138:55)
      at callFn (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runnable.js:326:21)
      at Test.Runnable.run (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runnable.js:319:7)
      at Runner.runTest (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:422:10)
      at C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:528:12
      at next (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:342:14)
      at C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:352:7
      at next (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:284:14)
      at Immediate.<anonymous> (C:\src\mozilla.org\mozilla-central\devtools\client\webconsole\node_modules\mocha\lib\runner.js:320:5)
Attachment #8872283 - Flags: review?(odvarko) → review+

Updated

9 months ago
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Iteration: --- → 55.6 - May 29
Priority: P2 → P1
(Assignee)

Comment 3

9 months ago
mozreview-review-reply
Comment on attachment 8872283 [details]
Bug 1367395 - Fix mocha filter component test.

https://reviewboard.mozilla.org/r/143784/#review147584

This one will be fixed by my patch on movig the filtering to the reducer
(Assignee)

Comment 4

9 months ago
TRY is green, pushing

Comment 5

9 months ago
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b891f690b98
Fix mocha filter component test. r=Honza
backed out for eslint failure like https://treeherder.mozilla.org/logviewer.html#?job_id=102957943&repo=autoland
Flags: needinfo?(nchevobbe)
(Assignee)

Comment 7

9 months ago
Thanks. I fixed the error, ensured it was fixed with `mach eslint`, and will push again
Flags: needinfo?(nchevobbe)
Comment hidden (mozreview-request)

Comment 9

9 months ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7163dcdf54dc
Backed out changeset 9b891f690b98 for eslint failure

Comment 10

9 months ago
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e05ee5231980
Fix mocha filter component test. r=Honza

Comment 11

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e05ee5231980
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

9 months ago
Iteration: 55.6 - May 29 → 55.7 - Jun 12
You need to log in before you can comment on or make changes to this bug.