Web UI ally: large fonts make log inaccessible

RESOLVED FIXED

Status

Tree Management
Treeherder: Log Viewer
P3
normal
RESOLVED FIXED
a year ago
7 months ago

People

(Reporter: pbone, Assigned: camd)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
When viewing a log page such as: https://treeherder.mozilla.org/logviewer.html#?job_id=101309399&repo=try&lineNumber=7197 Increasing the browser's font size makes the log move out of the browser's viewport and it cannot be scrolled to see the log.

Updated

9 months ago
Component: Treeherder → Treeherder: Log Viewer
(Assignee)

Comment 1

7 months ago
I think the fix here would be to just add a min-height like such:

.logview-container {
    flex: 1;
    overflow: hidden;
    min-height: 100px;
}
(Assignee)

Comment 2

7 months ago
Stage is slightly better now.  So the fix above would most likely take care of the issue:

https://treeherder.mozilla.org/logviewer.html#?job_id=144335705&repo=mozilla-central
https://treeherder.allizom.org/logviewer.html#?job_id=137268035&repo=mozilla-central

And adding the one line above should fix the bug.
(Assignee)

Updated

7 months ago
Priority: -- → P3

Comment 3

7 months ago
Created attachment 8928030 [details] [review]
[treeherder] mozilla:log-viewer-ally > mozilla:master
(Assignee)

Updated

7 months ago
Attachment #8928030 - Flags: review?(emorley)

Comment 4

7 months ago
Comment on attachment 8928030 [details] [review]
[treeherder] mozilla:log-viewer-ally > mozilla:master



Tested locally - looks good :-)
Attachment #8928030 - Flags: review?(emorley) → review+

Updated

7 months ago
Assignee: nobody → cdawson

Updated

7 months ago
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.