1367452 - Intermittent Assertion failed: false, file c:/builds/moz2_slave/gfx-w64-d-00000000000000000000/build/src/gfx/angle/src/libANGLE/renderer/d3d/SurfaceD3D.cpp, line 259

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Treeherder Bug Filer]

Filed by: kgupta [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=101581681&repo=graphics

https://archive.mozilla.org/pub/firefox/tinderbox-builds/graphics-win64-debug/1495630467/graphics_win8_64-debug_test-reftest-qr-e10s-1-bm109-tests1-windows-build4.txt.gz

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://archive.mozilla.org/pub/firefox/tinderbox-builds/graphics-win64-debug/1495630467/graphics_win8_64-debug_test-reftest-qr-e10s-1-bm109-tests1-windows-build4.txt.gz&only_show_unexpected=1

These QR reftest jobs weren't crashing previously (although they were failing, which is bug 1365250). With the latest merge from m-c they started asserting and crashing.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Note that only the debug jobs have this assertion, the opt job seems to be behaving as before (no crash, but reftest failures)

Comment 2

[Kartikaya Gupta (email:[e-mail])]

For the record, the assertion failure is at http://searchfox.org/mozilla-central/rev/2933592c4a01b634ab53315ce2d0e43fccb82181/gfx/angle/src/libANGLE/renderer/d3d/SurfaceD3D.cpp#259

Comment 3

[Kartikaya Gupta (email:[e-mail])]

The assertion failure might be a result of something else. On IRC jeff said that it might happen if the window goes away. There is another assertion in the log, at [1], although that happens later in the log. I assumed that was a result of the previous exception but I don't really know. I would think that both assertions would happen in the GPU process though.

[1] http://searchfox.org/mozilla-central/rev/6c2dbacbba1d58b8679cee700fd0a54189e0cf1b/gfx/layers/wr/WebRenderBridgeParent.cpp#676

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I can't reproduce the assertion on a local debug win64-qr build.

Comment 5

[Intermittent Failures Robot]

10 failures in 891 pushes (0.011 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* graphics: 10

Platform breakdown:
* windows8-64: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1367452&startday=2017-05-22&endday=2017-05-28&tree=all

Comment 6

[Sotaro Ikeda [:sotaro]]

I could not reproduce the same assertion, but I could reproduce the following assertion

err: rx::SurfaceD3D::resizeSwapChain(165): 	! Assert failed in rx::SurfaceD3D::resizeSwapChain(165): backbufferWidth >= 0 && backbufferHeight >= 0
Assertion failed: backbufferWidth >= 0 && backbufferHeight >= 0, file c:/quantum_gfx_src_1/graphics/gfx/angle/src/libANGLE/renderer/d3d/SurfaceD3D.cpp, line 165

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Prevent ClientSize becomes minus value

Comment 8

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8873350 [details] [diff] [review]
patch - Prevent ClientSize becomes minus value

Sorry, I posted a patch to a wrong bug.

Comment 9

[Intermittent Failures Robot]

16 failures in 820 pushes (0.02 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* graphics: 16

Platform breakdown:
* windows8-64: 16

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1367452&startday=2017-05-29&endday=2017-06-04&tree=all

Comment 10

[Sotaro Ikeda [:sotaro]]

It seems to be trigered by parent window destroy. When parent windows was destroyed, child windows was automatically destroyed.

http://searchfox.org/mozilla-central/source/widget/windows/nsWindow.cpp#984

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add DestroyLayerManager() to WM_DESTROY message

Comment 12

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c15a10c58e093c94b84fd2dd873b1878677c164d

Comment 13

[Sotaro Ikeda [:sotaro]]

attachment 8875275 [details] [diff] [review] addressed "SurfaceD3D.cpp, line 259" assert failure.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16fbe02d5cb5
Add DestroyLayerManager() to WM_DESTROY message r=jrmuizel

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/16fbe02d5cb5

Comment 16

[Kartikaya Gupta (email:[e-mail])]

My latest try push on Windows with QR forced on no longer has this crash. Verifying as fixed.