1367453 - browserSetting.remove should not throw an exception if the setting was not previously set

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Bob Silverberg [:bsilverberg]]

Currently, if an extension tries to clear a browserSetting (e.g., privacy.network.webRTCIPHandlingPolicy) that it has not previously set, an exception is thrown. We should not be throwing an exception in that case.

This was uncovered through Luca's testing of uBlock-origin on Android, but the bug exists on both desktop and Android and requires a fix to ExtensionSettingsStore.jsm in the alterSetting method [1].

[1] http://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionSettingsStore.jsm#129

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1367453 - Do not throw an exception from ExtensionSettingsStore when trying to remove a setting that was not previously set,

This changes the behaviour of ExtensionSettingsStore so that attempting to remove a setting that was not previously set does
not throw an exception. This allows things like privacy.network.webRTCIPHandlingPolicy.clear() to be called without having
previously called privacy.network.webRTCIPHandlingPolicy.set().

Review commit: https://reviewboard.mozilla.org/r/142460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142460/

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8870891 [details]
Bug 1367453 - Do not throw an exception from ExtensionSettingsStore when trying to remove a setting that was not previously set,

https://reviewboard.mozilla.org/r/142460/#review146158

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bff7c4b4d2d9
Do not throw an exception from ExtensionSettingsStore when trying to remove a setting that was not previously set, r=mixedpuppy

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bff7c4b4d2d9