browserSetting.remove should not throw an exception if the setting was not previously set

RESOLVED FIXED in Firefox 55

Status

WebExtensions
General
P2
normal
RESOLVED FIXED
a year ago
a day ago

People

(Reporter: bsilverberg, Assigned: bsilverberg)

Tracking

unspecified
mozilla55
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [browserSetting] triaged)

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Currently, if an extension tries to clear a browserSetting (e.g., privacy.network.webRTCIPHandlingPolicy) that it has not previously set, an exception is thrown. We should not be throwing an exception in that case.

This was uncovered through Luca's testing of uBlock-origin on Android, but the bug exists on both desktop and Android and requires a fix to ExtensionSettingsStore.jsm in the alterSetting method [1].

[1] http://searchfox.org/mozilla-central/source/toolkit/components/extensions/ExtensionSettingsStore.jsm#129

Updated

a year ago
Blocks: 1309926
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8870891 [details]
Bug 1367453 - Do not throw an exception from ExtensionSettingsStore when trying to remove a setting that was not previously set,

https://reviewboard.mozilla.org/r/142460/#review146158
Attachment #8870891 - Flags: review?(mixedpuppy) → review+

Comment 3

a year ago
Pushed by bsilverberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bff7c4b4d2d9
Do not throw an exception from ExtensionSettingsStore when trying to remove a setting that was not previously set, r=mixedpuppy

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bff7c4b4d2d9
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

a day ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.