Pass a string instead of a comma seperated argument to mozlog for selinux permission problems in mozdevice

RESOLVED FIXED in Firefox 55

Status

Testing
Mozbase
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

In the log in bug 1367197 we saw the following error message:

WARNING: Unable to set SELinux Permissive due to %s.

This is because we're passing a comma-seperated set of arguments to the mozlog logger, which isn't supported (might be nice if it was, though based on a discussion on irc it looks like making it work that way would be non-trivial).
Checked the source and it appears this is the only case where we're doing this, so I'm just going to put up a quick patch and move on.
Comment hidden (mozreview-request)

Comment 3

6 months ago
mozreview-review
Comment on attachment 8870856 [details]
Bug 1367465 - Fix log message when setting selinux mode on Android fails

https://reviewboard.mozilla.org/r/142422/#review146030

Looks good.
Attachment #8870856 - Flags: review?(bob) → review+
Comment hidden (mozreview-request)

Comment 5

6 months ago
mozreview-review
Comment on attachment 8870874 [details]
Bug 1367465 - Bump mozdevice version to 0.51

https://reviewboard.mozilla.org/r/142448/#review146048

::: commit-message-cabbe:1
(Diff revision 1)
> +Bug 1367465 - Bump mozdevice version r=bc

Maybe include the version in the commit for ease of searching if someone is looking for it?
Attachment #8870874 - Flags: review?(bob) → review+
(Assignee)

Comment 6

6 months ago
mozreview-review
Comment on attachment 8870874 [details]
Bug 1367465 - Bump mozdevice version to 0.51

https://reviewboard.mozilla.org/r/142448/#review146066
Comment hidden (mozreview-request)

Comment 8

6 months ago
Pushed by wlachance@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/212187a1a1a5
Fix log message when setting selinux mode on Android fails r=bc
https://hg.mozilla.org/integration/autoland/rev/9c14c50c861c
Bump mozdevice version to 0.51 r=bc

Comment 9

6 months ago
syncing autophone...
https://github.com/mozilla/autophone/commit/3d8829c56e1a76402471eac07ae4ee858011eb99
Blocks: 1157427
https://hg.mozilla.org/mozilla-central/rev/212187a1a1a5
https://hg.mozilla.org/mozilla-central/rev/9c14c50c861c
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.