Closed Bug 1367482 Opened 3 years ago Closed 3 years ago

Changed behavior for Enter key - no more line breaks through keyboard utility

Categories

(Core :: Widget: Win32, defect)

52 Branch
All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
thunderbird_esr52 56+ fixed
firefox-esr52 --- wontfix
firefox54 --- wontfix
firefox55 --- wontfix
firefox56 --- fixed

People

(Reporter: martin.breidt, Assigned: masayuki)

References

Details

(Keywords: inputmethod, regression, Whiteboard: tpi:+)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170518000419

Steps to reproduce:

A recent update has apparently changed how Thunderbird reacts to key strokes sent from an external utility.

The free hotkey utility Clavier+ (available at http://utilfr42.free.fr/util/Clavier.php) allows to use keyboard shortcuts for sending text strings to Windows applications. When using a multi-line string (which means the utility must send an Enter key stroke), Thunderbird no longer creates a line break in the Compose Message window.

Detailed steps to reproduce:
1.) Install Clavier+ from http://utilfr42.free.fr/util/Clavier.php
2.) Create a new shortcut in Calvier+, e.g. for Win+Shift+V with the option to 'Write Text' and use a text that spans multiple lines
3.) In Thunderbird, compose a new message, then press the hotkey (Win+Shift+V)


Actual results:

The message window displays the correct text but all in one single line, without any line breaks.


Expected results:

The line breaks should also appear/be used
OS: Unspecified → Windows 7
Hardware: Unspecified → x86_64
I set this up. If you send text to Firefox, the newlines are also missing.

Masayuki-san, you work in this area, what can we tell the reporter?
Flags: needinfo?(masayuki)
Hmm, this should be a regression of bug 1300003. I think that we shouldn't ignore line break (0x0D).
Assignee: nobody → masayuki
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(masayuki)
Blocks: 1300003
Component: Message Compose Window → Widget: Win32
OS: Windows 7 → Windows
Product: Thunderbird → Core
Hardware: x86_64 → All
Whiteboard: tpi:+
Comment on attachment 8884492 [details]
Bug 1367482 NativeKey::HandleCharMessage() should treat a WM_CHAR message for '\r' as a Enter key press

https://reviewboard.mozilla.org/r/155304/#review160588
Attachment #8884492 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/bd802b54879e
NativeKey::HandleCharMessage() should treat a WM_CHAR message for '\r' as a Enter key press r=m_kato
https://hg.mozilla.org/mozilla-central/rev/bd802b54879e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Should this be considered for backport or can it ride the 56 train?
Flags: needinfo?(masayuki)
This is not so important, should ride the train.
Flags: needinfo?(masayuki)
Ah, but if some ESR52 users have trouble with this bug, it may be better to uplift them after released as 56. However, this is reported not so quickly after releasing 52.
This is still present in Thunderbird 52.2.1 and the fixed update is far away, right? A backport would be quite nice if feasible.
Thank you for fixing this!
Thunderbird team can take the fix even if we don't fix this bug.
Still present in Thunderbird 52.3.0...
Damn, I forgot to include this in 52.3, my apologies. I'll note it down for TB 52.4 now.
I've included it in TB 52.4 now. It will be fixed in that release coming up in the next few days.
Fixed in 52.4.0 - thank you very much!
You need to log in before you can comment on or make changes to this bug.