Remove extra error logging during device disconnect

RESOLVED FIXED in Firefox 55

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: udara.weera, Assigned: udara.weera)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Remove logs when disconnected id is different than the current device id.

FXA servers will now always send notifications to all devices, when any device is disconnected, so we don't need error logging for this scenario anymore.
(Assignee)

Updated

2 years ago
Blocks: 1339861
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8870968 - Flags: review?(eoger)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8870968 [details]
Bug 1367525 - Remove extra error logging during device disconnect.

https://reviewboard.mozilla.org/r/142532/#review146136

LGTM, thanks!
r+ with a fix of the commit message nitpick.

::: commit-message-37d77:1
(Diff revision 1)
> +Bugzilla #1367525 - Remove extra error logging during device disconnect

The format we use on the gecko tree is as follows:
Bug <Bug number> - <Commit message>. r?<reviewer(s)>

In that case it would be:

Bug 1367525 - Remove extra error logging during device disconnect. r?eoger
Attachment #8870968 - Flags: review?(eoger) → review+
Don't forget to assign yourself on the bug when you're working on it ;-)
Assignee: nobody → udara.weera
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P1
Comment hidden (mozreview-request)
I don't understand why we want to remove this.
Mark:
https://github.com/mozilla/fxa-auth-server/issues/1777

It doesn't hurt to do it anyway, we might need that message in the future.
Ah, I see, thanks

Comment 8

2 years ago
mozreview-review
Comment on attachment 8870968 [details]
Bug 1367525 - Remove extra error logging during device disconnect.

https://reviewboard.mozilla.org/r/142532/#review146562
Attachment #8870968 - Flags: review+

Comment 9

2 years ago
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb3190b6eb58
Remove extra error logging during device disconnect. r=eoger

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fb3190b6eb58
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.