Closed Bug 1367525 Opened 7 years ago Closed 7 years ago

Remove extra error logging during device disconnect

Categories

(Firefox :: Sync, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: udara.weera, Assigned: udara.weera)

References

Details

Attachments

(1 file)

Remove logs when disconnected id is different than the current device id.

FXA servers will now always send notifications to all devices, when any device is disconnected, so we don't need error logging for this scenario anymore.
Blocks: 1339861
Attachment #8870968 - Flags: review?(eoger)
Comment on attachment 8870968 [details]
Bug 1367525 - Remove extra error logging during device disconnect.

https://reviewboard.mozilla.org/r/142532/#review146136

LGTM, thanks!
r+ with a fix of the commit message nitpick.

::: commit-message-37d77:1
(Diff revision 1)
> +Bugzilla #1367525 - Remove extra error logging during device disconnect

The format we use on the gecko tree is as follows:
Bug <Bug number> - <Commit message>. r?<reviewer(s)>

In that case it would be:

Bug 1367525 - Remove extra error logging during device disconnect. r?eoger
Attachment #8870968 - Flags: review?(eoger) → review+
Don't forget to assign yourself on the bug when you're working on it ;-)
Assignee: nobody → udara.weera
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P1
I don't understand why we want to remove this.
Mark:
https://github.com/mozilla/fxa-auth-server/issues/1777

It doesn't hurt to do it anyway, we might need that message in the future.
Ah, I see, thanks
Comment on attachment 8870968 [details]
Bug 1367525 - Remove extra error logging during device disconnect.

https://reviewboard.mozilla.org/r/142532/#review146562
Attachment #8870968 - Flags: review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb3190b6eb58
Remove extra error logging during device disconnect. r=eoger
https://hg.mozilla.org/mozilla-central/rev/fb3190b6eb58
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: