Closed Bug 1367542 Opened 3 years ago Closed 3 years ago

Port Bug 1360891 to c-c. Replace the Places default favicon with an SVG.

Categories

(MailNews Core :: Build Config, enhancement)

enhancement
Not set

Tracking

(thunderbird55 affected, seamonkey2.52 affected)

RESOLVED FIXED
Thunderbird 55.0
Tracking Status
thunderbird55 --- affected
seamonkey2.52 --- affected

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file)

chrome://mozapps/skin/places/defaultFavicon.png is now chrome://mozapps/skin/places/defaultFavicon.svg
SeaMonkey tested. I don't expect problems with the other two products. Who can review this for IM? aleth seems to absent.
Attachment #8870991 - Flags: review?(rsx11m.pub)
Attachment #8870991 - Flags: review?(jorgk)
Comment on attachment 8870991 [details] [diff] [review]
1367542-defaultfavicon.patch

Richard will do a better review here.
Attachment #8870991 - Flags: review?(jorgk) → review?(richard.marti)
Comment on attachment 8870991 [details] [diff] [review]
1367542-defaultfavicon.patch

Thanks
Attachment #8870991 - Flags: review?(richard.marti) → review+
Patrick,
would you like to review it for im or should we just put it in?
Flags: needinfo?(clokep)
Comment on attachment 8870991 [details] [diff] [review]
1367542-defaultfavicon.patch

> modern.jar:
>-% override chrome://mozapps/skin/places/defaultFavicon.png chrome://communicator/skin/bookmarks/bookmark-item.png
>+% override chrome://mozapps/skin/places/defaultFavicon.svg chrome://communicator/skin/bookmarks/bookmark-item.png

So, the idea is that we keep our own PNG implementation (for now at least) and just disguise it as SVG?
Looks ugly, but with that hack working, should be ok until we have an SVG icon redesign at some time.
Attachment #8870991 - Flags: review?(rsx11m.pub) → review+
Let me take care of landing this. IB is usually OK with the things we do for them ;-)
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/d60f75d773252e42d92b614f9dab52b8988856c2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
> So, the idea is that we keep our own PNG implementation (for now at least) and just disguise it as SVG?
> Looks ugly, but with that hack working, should be ok until we have an SVG icon redesign at some time.

Yes. It works but I don't like it. I asked someone who does Graphics if he would be able to convert this one at least.
Flags: needinfo?(clokep)
Thanks for taking care of this. :) And straight ports are usually fine!
You need to log in before you can comment on or make changes to this bug.