Open Bug 1367579 Opened 3 years ago Updated 2 years ago

We should produce some kind of artifact summarizing compiler warnings to make it easier to determine what changed

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

People

(Reporter: wlach, Unassigned)

References

Details

After bug 1360764 landed and we started tracking warnings in perfherder, I took the liberty of putting informational warnings in bugs where the # of warnings increased:

https://bugzilla.mozilla.org/show_bug.cgi?id=1345368#c35
https://bugzilla.mozilla.org/show_bug.cgi?id=1359718#c25

However it's not easy to see *how* these patches increased the count, or what they increased, and are thus not particularly actionable. If we generated an artifact with the warnings in them, it would be relatively easy to create a tool that compared warning output between revisions using the treeherder and taskcluster api's (look up jobs for revisions + previous, get artifacts, diff the contents). Could we do that?
Flags: needinfo?(gps)
I thought I had filed this bug? If not, I've surely thought about it :)

The build systems produces a JSON file with warnings. It should be trivial to upload that as an artifact.

The build system has Python code for de-duping warnings, albeit crudely. See https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/compilation/warnings.py. I think we could throw in a similarity filter for more robust "new" and "fixed" warning detection so we could make actionable, per-warning alerts.
Flags: needinfo?(gps)
See Also: → 1383901
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.