Closed Bug 1367596 Opened 3 years ago Closed 3 years ago

Lots of white flashes when closing or switching tabs

Categories

(Firefox :: Tabbed Browser, defect, major)

55 Branch
All
Windows
defect
Not set
major

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox-esr45 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 + fixed

People

(Reporter: alice0775, Assigned: mconley)

References

Details

(Keywords: regression, reproducible)

Attachments

(2 files)

See Bug 1362866 Comment 71

I can also reproduce the content area white flashes
Thanks Alice0775 White. Do you have STR?
Flags: needinfo?(alice0775)
GHM113 posted in Mozillazine http://forums.mozillazine.org/viewtopic.php?p=14749371#p14749371

I've just reproduced white flashes when closing or switching tabs in a new profile.

STR:
Create new profile, launch it, open these urls in separate tabs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1285812
https://bugzilla.mozilla.org/show_bug.cgi?id=1322060
https://bugzilla.mozilla.org/show_bug.cgi?id=1334036
https://bugzilla.mozilla.org/show_bug.cgi?id=1366424
https://bugzilla.mozilla.org/show_bug.cgi?id=1364974

Press ctrl-1, start closing tabs using ctrl-w

AR: White flashes when closing tabs
ER: Tab contents should be rendered without white blank pages
Flags: needinfo?(alice0775)
Assignee: nobody → mconley
When you open those tabs, do you open them in the background? The tabs that are showing this flashing, had they been presented to you before?
Flags: needinfo?(alice0775)
(In reply to Mike Conley (:mconley) from comment #3)
> When you open those tabs, do you open them in the background?

Open them in background tab.

> The tabs that are showing this flashing, had they been presented to you before?

No.

I notice the white background when I first saw the content of that tab.
Flags: needinfo?(alice0775)
[Tracking Requested - why for this release]: Annoying (for eyes) regression

I can confirm this issue. Simply, not fully loaded and rendered tabs, which were opened in background, will blink and flash on white, after visiting that tab for first time.
Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: reproducible
Hardware: Unspecified → All
Hey Alice0775 White, are you able to post a brief screen recording so I can see how severe this problem is on your system?
Flags: needinfo?(alice0775)
I'm also seeing pages just plain not load when I click a link from a program like Instantbird - or they might be loading, but the tab stays white. The only way to fix it is to copy the link and load it in a new tab. Could that be the same bug? I've mostly seen it by clicking on links from my Twitter timeline using Instantbird, but I think it affects all links (but I'm not sure it's consistent - just frequent).
(In reply to Emanuel Hoogeveen [:ehoogeveen] from comment #7)
> I'm also seeing pages just plain not load when I click a link from a program
> like Instantbird - or they might be loading, but the tab stays white. The
> only way to fix it is to copy the link and load it in a new tab. Could that
> be the same bug? I've mostly seen it by clicking on links from my Twitter
> timeline using Instantbird, but I think it affects all links (but I'm not
> sure it's consistent - just frequent).

Is Firefox minimized when this occurs? If so, then this is likely bug 1367964, which has a fix incoming.
Flags: needinfo?(emanuel.hoogeveen)
Thanks for the pointer, I think that's it. I hadn't realized that Firefox being minimized was a consistent factor! I'll keep an eye on that bug.
Flags: needinfo?(emanuel.hoogeveen)
Flags: needinfo?(alice0775)
Thanks Alice0775 White, much appreciated. I understand what's happening.

I think I might be able to get around this while keeping the perceived performance improvement (and the improvement in clients seeing spinners) by only blanking for tabs that:

a) Have not presented AND
b) Have not fully finished loading

If a tab has finished loading, I think we should go ahead and attempt to paint it without doing the initial blank out.

I'll try to have a patch together on Monday.
tracking as new regression in 55.
Comment on attachment 8872457 [details]
Bug 1367596 - Don't show blank for tabs that haven't presented if they've loaded a non-blank page and are not busy. "

https://reviewboard.mozilla.org/r/143958/#review148528
Attachment #8872457 - Flags: review?(wmccloskey) → review+
hg error in cmd: hg pull gecko -r 67fba159b9cd68c183b0660df7f4dd1f0266209f: pulling from https://reviewboard-hg.mozilla.org/gecko
abort: HTTP Error 500: Internal Server Error
hg error in cmd: hg pull gecko -r 67fba159b9cd68c183b0660df7f4dd1f0266209f: pulling from https://reviewboard-hg.mozilla.org/gecko
abort: HTTP Error 500: Internal Server Error
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fb99ac0fe4e3
Don't show blank for tabs that haven't presented if they've loaded a non-blank page and are not busy. r=billm"
https://hg.mozilla.org/mozilla-central/rev/fb99ac0fe4e3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this Bug on Nightly  55.0a1 (2017-05-24) on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 55.0a1

Build ID 	20170601030206
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170531]
(In reply to Saddam Hossain from comment #19)
> I have reproduced this Bug on Nightly  55.0a1 (2017-05-24) on Windows 10, 64
> Bit!
> 
> The bug's fix is now verified on latest  Nightly 55.0a1
> 
> Build ID 	20170601030206
> User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0)
> Gecko/20100101 Firefox/55.0
> 
> [bugday-20170531]

I can't confirm that, I can still reproduce this bug in Nightly 01-06-17 aka 20170601030206 with a new profile using str from comment 2. I am using Intel Graphics 2000 aka i5 2300 integrated graphics.
Thanks Saddam, but this patch didn't land in mozilla-central in time to make the most recent Nightly. It should be in tomorrow's Nightly and can be verified then.
I've been usung Nightly for a couple of days after this bug landed and I think this approach has a serious flow so I ni Mike Conley. I am talking about white flashes when switching to a loading tab. Surprisingly, I come across these flashes quite often in 4 cases:

1. Websites that never finish loading
STR: open these links in the background using ctrl-lmb then switch to these tabs:
https://videocardz.com/

http://sport.rbc.ru/news/5932b86a9a79471454bd0f43
http://www.rbc.ru/politics/03/06/2017/5932009b9a7947cd10c36271

You'll see annoying white flashes.

2. Websites with 3rd-party content (images, video,etc)
Imagine you open a screenshot thread on a gaming forum with lots embedded images from imgur.com or other image hosting. There are lots of images on a page and all of them are high resolution so it will take a while before they all load.

What happens without this patch: left click on tab - contents of the page are rendered immediately, some images have already finished loading, other images are slowly appearing one after the other

What happens with this patch: left click on tab - white flash - contents of the page are rendered, some images have already finished loading, other images are slowly appearing one after the other

STR:
Open these links in the background using ctrl-left click, count to seven then switch to the 1st neogaf tab, you should see the flash. If not, switch to the 2nd neogaf tab, then to the 3rd tab.
http://www.neogaf.com/forum/showthread.php?t=1329720&page=60
http://www.neogaf.com/forum/showthread.php?t=1329720&page=59
http://www.neogaf.com/forum/showthread.php?t=1329720&page=58

3. Websites with 3rd-party content (images, video, etc) that is overloaded or doesn't respond
Same as #2, basically, but imagine that image/video hosting is overloaded or doesn't respond at all. 

Without this patch: left click on tab - contents of the page are rendered immediately, no images but that's not a problem
With this patch: left click on tab - white flash - contents of the page are rendered, no images

4. When loading a bunch of bookmarks using "Open all in tabs" on a slow CPU/notebook CPU. 
In my own experience, after you open many bookmarks at once, it might take a long time before all tabs stop loading completely. However, the key elements of the web pages like background or text are usually rendered much faster so it makes sense to switch to the tab before it finishes loading. As you've already guessed, you'll inevitably see white flashes in this case.
Flags: needinfo?(mconley)
A tentative plan to help reduce the remaining flashes has been laid out in bug 1371884.
Flags: needinfo?(mconley)
Blocks: 1374768
You need to log in before you can comment on or make changes to this bug.