Closed Bug 1367621 Opened 7 years ago Closed 7 years ago

opening a new tab no longer focuses in the url bar in fullscreen

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: mozilla, Assigned: mconley)

References

Details

(Keywords: regression)

Attachments

(2 files)

Bug 1367621 - Make sure to focus the URL bar for 'empty' tabs even while in full screen.
59 bytes, text/x-review-board-request
Felipe
: review+
Details
Bug 1367621 - Regression test to ensure that the URL bar is focused when new tabs are opened in fullscreen mode.
59 bytes, text/x-review-board-request
Felipe
: review+
Details 
STR:

cmd-T, type url or shortcut

Expected:

Typing shows up in url bar

Actual:

Typing disappears into the void

Fx Nightly, 55.0a1 (2017-05-24) (64-bit)
Built from https://hg.mozilla.org/mozilla-central/rev/291a11111bdd05c5cd55dd552da4b1285ceba9b2
Keywords: regression
This seems to be a matter of how fast I start typing in the new tab... there's a lag before the url bar gets focus, and if I start typing beforehand, it doesn't get focus.
This seems to stop when I restart with addons disabled, then I restart with addons enabled again, and it's fine.  Then I start seeing it again later.  Because of this, I'm not entirely sure if it's a problem that shows up at certain times (after using the browser a while?) or if there's a problem with my profile or addons.
Aki: I don't see this using today's nightly on Mac: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:54.0) Gecko/20100101 Firefox/54.0 ID:20170522172523 CSet: a6edfa473c7dde50edc14a85374eb400e5ada494

Any errors in the browser console?
Hm.
Could be related to tweetdeck in another tab and/or the tweetdeck square loading in the new tab page?
These are browser console errors after I hit "new tab", and the focus wasn't in the url bar.

Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. ExtensionCommon.jsm:270
Sending message that cannot be cloned. Are you trying to send an XPCOM object? MessageChannel.jsm:558:6
Loading failed for the <script> with source “https://ssl.google-analytics.com/ga.js”.  tweetdeck.twitter.com:1
Sending message that cannot be cloned. Are you trying to send an XPCOM object?  MessageChannel.jsm:558:6
TweetDeck initialisation failed  bundle.19ee535f4e.js:39
<unavailable>  bundle.19ee535f4e.js:39
Sending message that cannot be cloned. Are you trying to send an XPCOM object? MessageChannel.jsm:558:6
Sending message that cannot be cloned. Are you trying to send an XPCOM object? MessageChannel.jsm:558:6
Loading failed for the <script> with source “https://ssl.google-analytics.com/ga.js”.  tweetdeck.twitter.com:1
Sending message that cannot be cloned. Are you trying to send an XPCOM object?  MessageChannel.jsm:558:6
1495727272707	Toolkit.Telemetry	WARN	TelemetryStorage::_scanArchive - have seen this id before: 67ec30b7-7b28-3e43-8dc3-df3bf9032ec7, overwrite: false
XML Parsing Error: no root element found
Location: https://tweetdeck.twitter.com/metrics
Line Number 1, Column 1:  metrics:1:1
XML Parsing Error: no root element found
Location: https://tweetdeck.twitter.com/metrics
Line Number 1, Column 1:  metrics:1:1
XML Parsing Error: no root element found
Location: https://tweetdeck.twitter.com/metrics
Line Number 1, Column 1:  metrics:1:1
This is happening immediately on reopen in my main profile. Addons:

Open With
Privacy Badger
Tab Groups
Test Pilot
wxIF

HTTPS Everywhere (disabled)
Min Vid (disabled)
Sea Containers (disabled).

I have a no-addon, new profile browser, with just Tweetdeck loaded. Getting the same errors but not the same behavior, yet.  Going to try restarting my main profile browser without addons.
Same behavior in my main profile, with addons disabled... Immediately after restart, cmd-T doesn't focus the URL bar, when I'm going from a webpage.  When I cmd-T from the new tab page, it focuses the URL bar on the new new tab.
In a new private browsing window in my main profile, it seems to work fine, though I'm not sure if it's something about my other loaded tabs that's doing this.  In a new non-e10s window, new tab seems to work but it lags a bit, and the tweetdeck icon has a partially loading semi-circle.
In my main profile browsing window (e10s enabled, addons disabled), disabling the top sites in favor for an empty page doesn't fix things.
TypeError: this.controller is undefined[Learn More]  browserPlacesViews.js:261:1
I backed up my profile, then

Help -> Troubleshooting Information -> Refresh Nightly

In my refreshed main profile with no addons installed, I'm still seeing this behavior.
I can reproduce this on a new profile but only when Nightly is in full screen (on mac):

If focus is in the location bar and I open a new tab (either cmd-T or click button), the location bar will keep focus.

If about:newtab is already open and location bar doesn't have focus, opening a new tab will focus the location bar.

Otherwise, opening a new tab will not have focus in the location bar.
Ah, yes!  My main profile browser window is almost always full screen.  Thank you!
Summary: opening a new tab no longer focuses in the url bar → opening a new tab no longer focuses in the url bar in fullscreen
Bisected to bug 1362866 and https://hg.mozilla.org/mozilla-central/rev/9a89e9597191 does seem to touch full screen and url bar!
Blocks: 1362866
Flags: needinfo?(mconley)
status-firefox54: --- → unaffected
status-firefox55: --- → affected
Component: Keyboard Navigation → Tabbed Browser
Assignee: nobody → mconley
Comment on attachment 8871790 [details]
Bug 1367621 - Make sure to focus the URL bar for 'empty' tabs even while in full screen.

https://reviewboard.mozilla.org/r/143242/#review147006
Attachment #8871790 - Flags: review?(felipc) → review+
Comment on attachment 8871817 [details]
Bug 1367621 - Regression test to ensure that the URL bar is focused when new tabs are opened in fullscreen mode.

https://reviewboard.mozilla.org/r/143286/#review147070
Attachment #8871817 - Flags: review?(felipc) → review+
Comment on attachment 8871817 [details]
Bug 1367621 - Regression test to ensure that the URL bar is focused when new tabs are opened in fullscreen mode.

https://reviewboard.mozilla.org/r/143286/#review147104

::: browser/base/content/test/newtab/browser_newtab_fullscreen_focus.js:13
(Diff revision 2)
> +  let enterFs = BrowserTestUtils.waitForEvent(window, "fullscreen");
> +  BrowserFullScreen();
> +  await enterFs;
> +

I had to set the event handler before calling BrowserFullScreen(), because apparently on Windows, the event is fired in the same tick.
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92cd7b48120b
Make sure to focus the URL bar for 'empty' tabs even while in full screen. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/fedfdd4d63bc
Regression test to ensure that the URL bar is focused when new tabs are opened in fullscreen mode. r=Felipe
Flags: needinfo?(mconley)
Backed out in https://hg.mozilla.org/integration/autoland/rev/e2f55539f966 for breaking the next test to run after yours, browser_newtab_perwindow_private_browsing.js, on OS X, https://treeherder.mozilla.org/logviewer.html#?job_id=102458754&repo=autoland
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f8c4c8424429
Make sure to focus the URL bar for 'empty' tabs even while in full screen. r=Felipe
https://hg.mozilla.org/integration/autoland/rev/50861508d559
Regression test to ensure that the URL bar is focused when new tabs are opened in fullscreen mode. r=Felipe
https://hg.mozilla.org/mozilla-central/rev/f8c4c8424429
https://hg.mozilla.org/mozilla-central/rev/50861508d559
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
This is resolved for me with today's nightly. Thanks!
Status: RESOLVED → VERIFIED
Depends on: 1394963
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: