Closed
Bug 136764
Opened 24 years ago
Closed 23 years ago
nsLineBox::DeleteLineList leaks lines
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.1alpha
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file, 1 obsolete file)
|
659 bytes,
patch
|
attinasi
:
review+
waterson
:
superreview+
|
Details | Diff | Splinter Review |
nsLineBox::DeleteLineList leaks lines (doesn't free them back to the pres
shell's arena) because it does |delete line;| instead of |line->Destroy(shell)|.
|
Assignee | |
Comment 1•24 years ago
|
||
|
|
Assignee | |
Updated•24 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.1alpha
|
|
Assignee | |
Comment 2•24 years ago
|
||
This is a little better. This is already within an IsEmpty check, so I can
turn the while loop into a do-while, saving one emptiness test.
Attachment #78648 -
Attachment is obsolete: true
|
||
Comment 3•24 years ago
|
||
Comment on attachment 78669 [details] [diff] [review]
slightly better patch
sr=waterson.
Attachment #78669 -
Flags: superreview+
|
|
||
Comment 4•24 years ago
|
||
Comment on attachment 78669 [details] [diff] [review]
slightly better patch
r=attinasi - good catch!
Attachment #78669 -
Flags: review+
|
|
Assignee | |
Comment 5•24 years ago
|
||
Fix checked in to trunk 2002-04-13 11:54 PDT.
|
||
Comment 6•23 years ago
|
||
Not sure how I can verify this. David, can you please change the status of this
bug to verified.
|
|
Assignee | |
Comment 8•23 years ago
|
||
Marking fixed, since I don't think I'll bother with this for the branch.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•