Clean up ProfileEntry

RESOLVED FIXED in Firefox 55

Status

()

Product:
Core
Component:
Gecko Profiler
RESOLVED FIXED
Reported:
11 months ago
Modified:
11 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

Version:
Trunk
Target:
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(3 attachments)

(part 1) - Clean up ProfileEntry
6.75 KB, patch
shu
: review+
Details | Diff | Splinter Review
(part 2) - In GeckoProfiler.h, rename Sampler* as Profiler*
7.75 KB, patch
mstange
: review+
Details | Diff | Splinter Review
(part 3) - Remove unnecessary BEGIN_PSEUDO_JS frame from AutoGeckoProfilerEntry
1.82 KB, patch
shu
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

•
11 months ago 
Created attachment 8871180 [details] [diff] [review]
(part 1) - Clean up ProfileEntry

This patch:

- renames flags_ as flagsAndCategory_ because it contains both the flags and
  the category;

- uses << for some bitfield definitions, because it's easier to read;

- removes some dead methods from ProfileEntry;

- removes the unnecessary JS_FRIEND_API from setPC().
Attachment #8871180 - Flags: review?(shu)
 (Assignee)

Updated

•
11 months ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
 (Assignee)

Comment 2

•
11 months ago 
Created attachment 8871181 [details] [diff] [review]
(part 2) - In GeckoProfiler.h, rename Sampler* as Profiler*

Because everything else in this file is called ProfilerFoo or PROFILER_FOO.
Attachment #8871181 - Flags: review?(mstange)
 (Assignee)

Comment 3

•
11 months ago 
Created attachment 8871182 [details] [diff] [review]
(part 3) - Remove unnecessary BEGIN_PSEUDO_JS frame from AutoGeckoProfilerEntry

BEGIN_PSEUDO_JS frames are necessary before a sequence of JS frames, in order
to provide a stack address. But in AutoGeckoProfilerEntry the BEGIN_PSEUDO_JS
frame is before a C++ frame, so it's useless.
Attachment #8871182 - Flags: review?(shu)

Updated

•
11 months ago
Attachment #8871180 - Flags: review?(shu) → review+

Updated

•
11 months ago
Attachment #8871182 - Flags: review?(shu) → review+

Updated

•
11 months ago
Attachment #8871181 - Flags: review?(mstange) → review+
 (Assignee)

Comment 5

•
11 months ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b82e5e570d6e28138167115fe74a2d5d32c9e07
Bug 1367654 (part 1) - Clean up ProfileEntry. r=shu.

https://hg.mozilla.org/integration/mozilla-inbound/rev/343d001b8dfe9746d5423d0d1fca61c248805cc9
Bug 1367654 (part 2) - In GeckoProfiler.h, rename Sampler* as Profiler*. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/735a87a03948ba9462017b37f64fed601444c7cd
Bug 1367654 (part 3) - Remove unnecessary BEGIN_PSEUDO_JS frame from AutoGeckoProfilerEntry. r=shu.

Comment 6

•
11 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/7b82e5e570d6
https://hg.mozilla.org/mozilla-central/rev/343d001b8dfe
https://hg.mozilla.org/mozilla-central/rev/735a87a03948
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.