1367662 - No longer possible to create a useful debug build

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

Bug 1364727 broke non-optimized debug builds; i.e. the thing you would want to be using to actually debug anything.

The failure is:

22:55.32 Undefined symbols for architecture x86_64:
22:55.32   "mozilla::Unused", referenced from:
22:55.32       PingSender::DummyWriteCallback(char*, unsigned long, unsigned long, void*) in Unified_cpp_pingsender0.o
22:55.33 ld: symbol(s) not found for architecture x86_64

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: We need to link the library that actually implements the thing we're including

Comment 2

[Alessio Placitelli [:Dexter]]

Mh, I wonder why we don't have any treeherder coverage for this build configuration if is such an important one.

Also, I'm not sure linking against mozglue is a solution here. I'd rather silence the warnings without using mozilla::Unused.

Comment 3

[Alessio Placitelli [:Dexter]]

(In reply to Alessio Placitelli [:Dexter] from comment #2)
> Also, I'm not sure linking against mozglue is a solution here. I'd rather
> silence the warnings without using mozilla::Unused.

Let me expand a bit on this, as I was too quick :)

We tried not to use other stuff from mozglue/xul, etc. to avoid linking against these libraries to keep the binary as simple and as small as possible. However, Gabriele knows more about this and can decide if it's ok to link against mozglue or not :)

Comment 4

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8871179 [details] [diff] [review]
We need to link the library that actually implements the thing we're including

While this works I think that the proper fix is to use GeckoProgram, i.e.:

GeckoProgram('pingsender', linkage=None)

instead of

Program('pingsender')

I didn't use GeckoProgram when I introduced the pingsender precisely because I wasn't using mozglue. BTW I thought that Unused.h was a pure template which is way I didn't think about this.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> I wonder why we don't have any treeherder coverage for this build configuration if is such an important one

Because the people setting up treeherder are not the people who have to actually debug Firefox.  This has been a perennial problem and a source of tons of wasted effort when things break, but repeated requests to have build coverage for basic debug builds keep getting ignored.

Comment 7

[Boris Zbarsky [:bzbarsky]]

> I thought that Unused.h was a pure template

It's totally not.  See Unused.cpp.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Link pingsender to mozglue if we're using things that are defined in mfbt

Comment 9

[Georg Fritzsche [:gfritzsche]]

(In reply to Boris Zbarsky [:bz] (work week until 5/26) (if a patch has no decent message, automatic r-) from comment #6)
> > I wonder why we don't have any treeherder coverage for this build configuration if is such an important one
> 
> Because the people setting up treeherder are not the people who have to
> actually debug Firefox.  This has been a perennial problem and a source of
> tons of wasted effort when things break, but repeated requests to have build
> coverage for basic debug builds keep getting ignored.

Gregory, do you happen to have an idea who to flag to make a basic compile smoke test happen?

Comment 10

[Boris Zbarsky [:bzbarsky]]

I filed bug 1367751 in yet another attempt to get tree coverage for this sort of thing.

Comment 11

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8871267 [details] [diff] [review]
Link pingsender to mozglue if we're using things that are defined in mfbt

Thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f43ff529c515
Link pingsender to mozglue if we're using things that are defined in mfbt.  r=gsvelto

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f43ff529c515