1367712 - Stop using a custom toolbar background color on Windows 7

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [::dao]]

Mockup: https://people-mozilla.org/~shorlander/projects/photon/Mockups/windows-7.html

Comment 1

[Dão Gottwald [::dao]]

Attachment: Bug 1367712 - Stop using a custom toolbar background color on Windows 7.

Review commit: https://reviewboard.mozilla.org/r/142726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142726/

Comment 2

[Nihanth Subramanya [:nhnt11]]

Comment on attachment 8871229 [details]
Bug 1367712 - Stop using a custom toolbar background color on Windows 7.

https://reviewboard.mozilla.org/r/142726/#review146430

I don't have a Win7 machine with which to test this immediately, but the changes look alright. I'm curious what the final effect of this patch is, can you post a screenshot? :)

Comment 3

[Dão Gottwald [::dao]]

Attachment: screenshot

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dc08e2b866b
Stop using a custom toolbar background color on Windows 7. r=nhnt11

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8dc08e2b866b

Comment 6

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=f7adbf457ee20eeffde72694e0d17d73616e3cfd&newProject=mozilla-central&newRev=bdf2d1918fb0b434ab8782d003afbe3f9639cd45

(Untoggle "known inconsistencies" and look at Windows 7)

Comment 7

[ovidiu boca[:Ovidiu]]

Attachment: comparing Nightly with screenshoots.png

I tested this issue on Windows 7 with the latest Nightly 57.0a1(2017-08-09) and I have different results from the one presented in Screenshots. Please see the attached file.

Comment 8

[Dão Gottwald [::dao]]

(In reply to ovidiu boca[:Ovidiu] from comment #7)
> Created attachment 8895364 [details]
> comparing Nightly with screenshoots.png
> 
> I tested this issue on Windows 7 with the latest Nightly 57.0a1(2017-08-09)
> and I have different results from the one presented in Screenshots. Please
> see the attached file.

The important part is that we're not using the blue toolbar color anymore.

Comment 9

[ovidiu boca[:Ovidiu]]

Thanks Dão, based on comment 8 I will mark this as verified fixed.