136773 - Investigate enabling ldap:5 logging on optimized builds.

Status: VERIFIED FIXED

(MailNews Core :: Address Book, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: 2002-04-10-03, Windows 2000.

Currently, the NSPR_LOG_MODULES=ldap:5, coupled with
NSPR_LOG_FILE=C:\WINNT\Temp\logfile.txt doesn't produce anything other than a
blank file.  The reason for this is that the logging code is probably ifdef#DEBUG.

In similar fashion to nntp:5, imap:5, etc, I think we should make a decision on
whether or not we'd like to enable this in the optimized builds.

Talked to Dan about this already, I'll need to measure the possible performance
implications to see whether or not this adversely affects users.

Comment 1

[Mark Banner (:standard8)]

Attachment: Current & proposed output.

I've been looking at this as I think it may aid users in diagnosing ldap connection problems. However I don't think we want to log everything, as that will probably impair performance, especially with logging all the GetValues() items. Therefore I propose not including them in release builds (but keeping them in debug ones of course).

The file I'm attaching gives an example log of what it will look like once the patch is done.

Comment 2

[Mark Banner (:standard8)]

Attachment: Allow logging ldap:5 on optimized builds

This patch does what i suggested, but removes the InvokeMessageCallback and adds "nsLDAPMessage::GetDn(): dn = 'whatever'" in its place for displaying cards.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 207740 [details] [diff] [review]
Allow logging ldap:5 on optimized builds

r+sr=dmose; thanks Mark!

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 207740 [details] [diff] [review]
Allow logging ldap:5 on optimized builds

Checked in to trunk.

Requesting approval for 1.8.1 branch. This is a low-risk enabling of logging facilities that have been in debug builds for a long time. It should give our ldap users much easier ways to  work out what is happening with the connections.

Comment 5

[Mark Banner (:standard8)]

This is fixed on trunk, so marking as fixed. Hopefully drivers will approval 1.8.1 so I'll check it in on branch when the approval comes.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

In my trunk, opt 2006-01-16-09 SeaMonkey build under Windows XP:

--Compose widget--

5124[2a9d0d8]: nsLDAPConnection::Run() entered
0[2746f8]: nsLDAPOperation::SimpleBind(): called; bindName = 'ads\stdonner'; 
0[2746f8]: pending operation added; total pending operations now = 1
5124[2a9d0d8]: pending operation removed; total pending operations now = 0
0[2746f8]: nsLDAPOperation::SearchExt(): called with aBaseDn = 'dc=ads,dc=iu,dc=edu'; aFilter = '(|(cn=wq**)(mail=wq**)(sn=wq**))', aAttrCounts = 2, aSizeLimit = 100
0[2746f8]: pending operation added; total pending operations now = 1
5124[2a9d0d8]: pending operation removed; total pending operations now = 0
5124[2a9d0d8]: unbinding
5124[2a9d0d8]: unbound

--Address Book--

4128[23939a8]: nsLDAPConnection::Run() entered
0[2746f8]: nsLDAPOperation::SimpleBind(): called; bindName = 'ads\stdonner'; 
0[2746f8]: pending operation added; total pending operations now = 1
0[2746f8]: nsLDAPOperation::SearchExt(): called with aBaseDn = 'dc=ads,dc=iu,dc=edu'; aFilter = '(|(mail=*stephen*)(displayName=*stephen*)(givenName=*stephen*)(sn=*stephen*))', aAttrCounts = 65, aSizeLimit = 100
0[2746f8]: pending operation added; total pending operations now = 2
4128[23939a8]: pending operation removed; total pending operations now = 1
0[2746f8]: nsLDAPMessage::GetDn(): dn = 'CN=sfultz,OU=Accounts,DC=ads,DC=iu,DC=edu'
0[2746f8]: nsLDAPMessage::GetDn(): dn = 'CN=sfultz,OU=Accounts,DC=ads,DC=iu,DC=edu'
0[2746f8]: nsLDAPMessage::GetDn(): dn = 'CN=watt,OU=Accounts,DC=ads,DC=iu,DC=edu'
0[2746f8]: nsLDAPMessage::GetDn(): dn = 'CN=smartino,OU=Accounts,DC=ads,DC=iu,DC=edu'
0[2746f8]: nsLDAPMessage::GetDn(): dn = 'CN=ssimms,OU=Accounts,DC=ads,DC=iu,DC=edu'
0[2746f8]: nsLDAPMessage::GetDn(): dn = 'CN=msskelto,OU=Accounts,DC=ads,DC=iu,DC=edu'
0[2746f8]: nsLDAPMessage::GetDn(): dn = 'CN=mollier,OU=Accounts,DC=ads,DC=iu,DC=edu'
4128[23939a8]: pending operation removed; total pending operations now = 0
4128[23939a8]: unbinding
4128[23939a8]: unbound

Verified FIXED