1367732 - pingsender build failure on macOS + debug local build

Status: RESOLVED DUPLICATE of bug 1367662

(Toolkit :: Telemetry, defect)

Description

[Jonathan Kew [:jfkthame]]

My local debug build on macOS fairly recently started failing with

 0:39.29 /Users/jkew/mozdev/mozilla-central/obj-x86_64-apple-darwin16.1.0/toolkit/components/telemetry/pingsender/tmpw_qjlb.list:
 0:39.29     Unified_cpp_pingsender0.o
 0:39.29     ../../../../modules/zlib/src/adler32.o
 0:39.29     ../../../../modules/zlib/src/compress.o
 0:39.29     ../../../../modules/zlib/src/crc32.o
 0:39.29     ../../../../modules/zlib/src/deflate.o
 0:39.29     ../../../../modules/zlib/src/gzclose.o
 0:39.29     ../../../../modules/zlib/src/gzlib.o
 0:39.29     ../../../../modules/zlib/src/gzread.o
 0:39.30     ../../../../modules/zlib/src/gzwrite.o
 0:39.30     ../../../../modules/zlib/src/infback.o
 0:39.30     ../../../../modules/zlib/src/inffast.o
 0:39.30     ../../../../modules/zlib/src/inflate.o
 0:39.30     ../../../../modules/zlib/src/inftrees.o
 0:39.30     ../../../../modules/zlib/src/trees.o
 0:39.30     ../../../../modules/zlib/src/uncompr.o
 0:39.30     ../../../../modules/zlib/src/zutil.o
 0:39.30 
 0:39.30 Undefined symbols for architecture x86_64:
 0:39.30   "mozilla::Unused", referenced from:
 0:39.30       PingSender::DummyWriteCallback(char*, unsigned long, unsigned long, void*) in Unified_cpp_pingsender0.o
 0:39.30 ld: symbol(s) not found for architecture x86_64
 0:39.30 clang: error: linker command failed with exit code 1 (use -v to see invocation)

I'm not sure why this isn't affecting builds in automation. Maybe it's just me, though the local mozconfig I was using is pretty simple:

    . $topsrcdir/browser/config/mozconfig

    ac_add_options --enable-debug
    ac_add_options --disable-optimize
    ac_add_options --with-ccache
    mk_add_options AUTOCLOBBER=1

Adding 'mfbt' to the LIBS for building the pingsender tool seems to resolve it for me.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Add mfbt to LIBS when linking pingsender

Can we simply do this to help anyone who runs into the same issue I did (without disrupting other builds)?

Comment 3

[Jonathan Kew [:jfkthame]]

Oh, never mind, I see this got duped already while I was attaching the patch!

Comment 4

[Alessio Placitelli [:Dexter]]

(In reply to Jonathan Kew (:jfkthame) from comment #3)
> Oh, never mind, I see this got duped already while I was attaching the patch!

Whoosh :-D Sorry, I just saw this floating by!