136774 - Can't create plaintext editor through embedding API

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Dan McGuirk]

I'd like to create a plaintext editor using the embedding APIs, but this doesn't 
appear to be possible.  (nsEditingSession::SetupEditorOnWindow has the HTML 
editor contract ID hardcoded.)

I can create the HTML editor and then set the eEditorPlaintextMask flag using 
nsIEditor::SetFlags, but that's not the same thing.

Comment 1

[Simon Fraser [no longer active]]

Confirming.

Comment 2

[Adam Lock]

Reassigning.

Comment 3

[Simon Fraser [no longer active]]

->saari

Comment 4

[saari (gone)]

-> mjudge

Comment 5

[mjudge]

moving to 1.01

Comment 6

[Kathleen :Brade]

changing component so this shows up in Syd's editor embedding queries

Comment 7

[mjudge]

Attachment: patch to flow through editortype to the actual editor flags as well as the classid

patched from mozilla/editor/composer

Comment 8

[Kathleen :Brade]

Comment on attachment 102232 [details] [diff] [review]
patch to flow through editortype to the actual editor flags as well as the classid

if the string passed in is null, do we want to create html by default and
return an error?

Interestingly, in editorShell, a plaintext editor is never really created; it
always creates an html editor

The comment in the idl file should be changed to match up with the editor types
we accept (htmlmail, textmail, html, text for now)

We need to handle the case of "textmail" which is an htmleditor but has the
mailmask flag (see editorshell).

I don't see any need to add "aEditorType" to setupEditorOnWindow; it isn't used
there.

Comment 9

[mjudge]

Attachment: try 2. fix for setupeditoronwindow

working with cmanske to fix this

Comment 10

[mjudge]

Attachment: patch from editor/composer

fixes kathy's issues. adds smarts for textmail.  Also leaves door open for
further additions of different types of editors.  Right now I still keep the
mEditorType string in there even though they all use the same.	This is because
we may need to change this soon for embedders.

Comment 11

[jag (Peter Annema)]

Comment on attachment 102282 [details] [diff] [review]
patch from editor/composer

>Index: src/nsEditingSession.cpp
>===================================================================
>-nsEditingSession::MakeWindowEditable(nsIDOMWindow *aWindow, PRBool inDoAfterUriLoad)
>+nsEditingSession::MakeWindowEditable(nsIDOMWindow *aWindow, const char *aEditorType, PRBool inDoAfterUriLoad)
> {
>+  PRBool htmlController = PR_FALSE;
>+  mEditorType = nsnull;
>+  mEditorFlags = 0;
>+  mEditorType = "@mozilla.org/editor/htmleditor;1";

Maybe add a comment here that this is transitional.

>+  const char *editortype = nsnull;

Unused code?

sr=jag with these nits addressed.

Comment 12

[mjudge]

Attachment: patch from editor/composer

fixes stuff from jags comments.  remove dead code and added a comment

Comment 13

[mjudge]

Comment on attachment 102284 [details] [diff] [review]
patch from editor/composer

carrying over SR

Comment 14

[Charles Manske]

Comment on attachment 102282 [details] [diff] [review]
patch from editor/composer

why not use 
: mDoneSetup(PR_FALSE)
, mEditorType(nsnull
in the constructor?

I wonder if you should call mEditorType something else since it's not the same
as the passed in aEditorType ?
mEditorComponent ?

Comment 15

[mjudge]

ok no prob I will make changes before commiting.

Comment 16

[Charles Manske]

Comment on attachment 102284 [details] [diff] [review]
patch from editor/composer

r=cmanske, but please 
consider the comments I mentioned in previous patch.
Note that I actually tested this for Composer in an experimental build that has
no editorShell.
But my Mail tree is hosed so I couldn't test that part.

Comment 17

[Kathleen :Brade]

resolving this as fixed since Mike says he checked it in

Comment 18

[David Epstein]

Patch verified against Mozilla 1.2b Mozilla/5.0 (Windows; U; WinNT4.0; en-US;
rv:1.2b) Gecko/20021026 build. mEditorType is now mEditorClassString and (const
char *editortype = null) line was removed.