[mozharness] Log 'process_output' messages at the proper mozharness level with StructuredOutputParser

RESOLVED FIXED

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

2 years ago
In the StructuredOutputParser, we pass 'data' portion of 'process_output' messages to the BaseOutputParser so we can run the regex error lists against them.

But we don't save what the computed log level was, which means they'll always be logged at INFO (even if an error was detected). Because of this, treeherder won't include these lines in its error summary.
Assignee

Updated

2 years ago
Assignee: nobody → ahalberstadt
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Comment 3

2 years ago
Because this touches logging and can therefore break random tasks, here's a fairly comprehensive try run:
https://treeherder.mozilla.org/#/jobs?repo=try&author=ahalberstadt@mozilla.com

Comment 4

2 years ago
mozreview-review
Comment on attachment 8871419 [details]
Bug 1367745 - Use same error lists in wpt as in mochitest,

https://reviewboard.mozilla.org/r/142894/#review146928
Attachment #8871419 - Flags: review?(james) → review+

Comment 5

2 years ago
mozreview-review
Comment on attachment 8871420 [details]
Bug 1367745 - Make sure 'process_output' messages are logged at the proper mozharness level,

https://reviewboard.mozilla.org/r/142896/#review146930
Attachment #8871420 - Flags: review?(james) → review+

Comment 6

2 years ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad1fa17ce50e
Use same error lists in wpt as in mochitest, r=jgraham
https://hg.mozilla.org/integration/autoland/rev/f19ff8201437
Make sure 'process_output' messages are logged at the proper mozharness level, r=jgraham

Comment 7

2 years ago
Backout by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b56fa748e7ec
Backed out changeset f19ff8201437 for causing Windows debug reftests to exceed the maximum log size.
Assignee

Comment 8

2 years ago
The super().parse_single_line function was returning INFO by default, which is technically "worse" than DEBUG. So things logged at the debug level were being transformed to INFO.

The fix is to get the super().parse_single_line to only return a level if there is a match in the error_list, and otherwise return None. That way we can only overwrite the log level if there was a match of the error_list.

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ad1fa17ce50e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Reopening since one of the two patches was backed out and needs relanding.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8871419 - Attachment is obsolete: true
Assignee

Updated

2 years ago
Attachment #8871419 - Attachment is obsolete: false
Assignee

Comment 13

2 years ago
Comment on attachment 8871420 [details]
Bug 1367745 - Make sure 'process_output' messages are logged at the proper mozharness level,

Asking for re-review as the fix was just complex enough to make me uncomfortable.
Attachment #8871420 - Flags: review+ → review?(james)
Attachment #8871420 - Flags: review?(james) → review+
Assignee

Comment 14

2 years ago
In addition to the previous try run, here's another general one just to be extra safe:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=719616bbce7ab885491f53379b708ce402b68b41

Comment 15

2 years ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/454c9ae2e8ba
Make sure 'process_output' messages are logged at the proper mozharness level, r=jgraham

Comment 16

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/454c9ae2e8ba
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.