Allow new keys in Histograms.json if !strict_type_checks

RESOLVED FIXED in Firefox 55

Status

()

P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: chutten, Assigned: raajitr, Mentored)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [lang=python])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
On the server side, histogram_tools doesn't need to be as strict as it is on client side. That's what strict type checks are for.

Let's expand this to allow new keys (like, say, the "keys" key from bug 1343855) so that we don't hamstring ourselves with requirements for tight synchronization of histogram_tools between client and server.
Mentor: gfritzsche, chutten
Priority: -- → P2
Whiteboard: [lang=python]
Comment hidden (mozreview-request)
Attachment #8871445 - Flags: review?(alessio.placitelli) → review?(chutten)
(Reporter)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8871445 [details]
Bug 1367750 - Allow new keys in Histograms.json if strict_type_checks is False

https://reviewboard.mozilla.org/r/142918/#review146950

Does this pass linting and building?
Attachment #8871445 - Flags: review?(chutten) → review+
Assignee: nobody → raajit.raj
(In reply to Chris H-C :chutten from comment #2)
> Comment on attachment 8871445 [details]
> Bug 1367750 - Allow new keys in Histograms.json if strict_type_checks is
> False
> 
> https://reviewboard.mozilla.org/r/142918/#review146950
> 
> Does this pass linting and building?
Flags: needinfo?(raajit.raj)
(Assignee)

Comment 4

2 years ago
(In reply to Georg Fritzsche [:gfritzsche] from comment #3)
> (In reply to Chris H-C :chutten from comment #2)
> > Comment on attachment 8871445 [details]
> > Bug 1367750 - Allow new keys in Histograms.json if strict_type_checks is
> > False
> > 
> > https://reviewboard.mozilla.org/r/142918/#review146950
> > 
> > Does this pass linting and building?

Yes, it is.
Flags: needinfo?(raajit.raj)

Comment 5

2 years ago
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9acc145b45e
Allow new keys in Histograms.json if strict_type_checks is False r=chutten

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f9acc145b45e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.