1367790 - Remove Search Suggestions notification opt-in code

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Marco Bonardo [:mak]]

Once we have shipped opt-out and we're fine with that, we should remove the duplicate code for opt-in that it's still in the tree. This should also allow to simplify some of the code to return a show/noshow bool instead of the kind of notification.

Comment 1

[Marco Bonardo [:mak]]

Javaun, can we do this now that we shipped the opt-out experience?
It would remove half of the code for search suggestions notifications, that would be nice for code maintainability.

Comment 2

[Marco Bonardo [:mak]]

Got an answer through mail, we can remove the opt-in code, but retain the notification selection code, so that in the future we can add different notifications.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1367790 - Remove code for the opt-in Search Suggestions notification.

Review commit: https://reviewboard.mozilla.org/r/188778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188778/

Comment 4

[:Paolo Amadini]

Comment on attachment 8917829 [details]
Bug 1367790 - Remove code for the opt-in Search Suggestions notification.

https://reviewboard.mozilla.org/r/188778/#review194048

Not sure there is value in keeping the deck, but we can always remove it later.

Comment 5

[Marco Bonardo [:mak]]

yep, I kept it in case we want to have new notifications. For example we could notify about unified experience when we enable for more users.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d5061981868
Remove code for the opt-in Search Suggestions notification. r=Paolo

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6d5061981868