Closed Bug 1367790 Opened 3 years ago Closed 2 years ago

Remove Search Suggestions notification opt-in code

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Once we have shipped opt-out and we're fine with that, we should remove the duplicate code for opt-in that it's still in the tree. This should also allow to simplify some of the code to return a show/noshow bool instead of the kind of notification.
Javaun, can we do this now that we shipped the opt-out experience?
It would remove half of the code for search suggestions notifications, that would be nice for code maintainability.
Flags: needinfo?(jmoradi)
Priority: P3 → P2
Got an answer through mail, we can remove the opt-in code, but retain the notification selection code, so that in the future we can add different notifications.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Flags: needinfo?(jmoradi)
Comment on attachment 8917829 [details]
Bug 1367790 - Remove code for the opt-in Search Suggestions notification.

https://reviewboard.mozilla.org/r/188778/#review194048

Not sure there is value in keeping the deck, but we can always remove it later.
Attachment #8917829 - Flags: review?(paolo.mozmail) → review+
yep, I kept it in case we want to have new notifications. For example we could notify about unified experience when we enable for more users.
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/6d5061981868
Remove code for the opt-in Search Suggestions notification. r=Paolo
https://hg.mozilla.org/mozilla-central/rev/6d5061981868
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Depends on: 1417016
You need to log in before you can comment on or make changes to this bug.