1367798 - fennec debug fails to build in netwerk/cache2 for some environments

Reporter

Description

•

7 years ago

Some users are having difficulty build debug fennec today.  We get errors like below.  It seems something landed very recently that is causing this.

Mozilla Pastebin - collaborative debugging tool View Help
Posted by Anonymous on Thu 25th May 15:18 (modification of post by view diff)
download | new post

    0:07.40 In file included from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/system_wrappers/memory:3:0,
     0:07.40                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/stl_wrappers/memory:44,
     0:07.40                  from /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/algorithm:628,
     0:07.40                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/system_wrappers/algorithm:3,
     0:07.40                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/stl_wrappers/algorithm:44,
     0:07.40                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/include/mozilla/Span.h:31,
     0:07.41                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/include/nsTArray.h:22,
     0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheIOThread.h:11,
     0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheFileIOManager.h:8,
     0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheFileChunk.h:8,
     0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheFile.h:8,
     0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheEntry.h:9,
     0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheStorage.h:9,
     0:07.41                  from /srv/mozilla-central/netwerk/cache2/AppCacheStorage.h:8,
     0:07.41                  from /srv/mozilla-central/netwerk/cache2/AppCacheStorage.cpp:6,
     0:07.41                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/netwerk/cache2/Unified_cpp_netwerk_cache20.cpp:2:
     0:07.41 /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/memory: In instantiation of 'void std::__ndk1::unique_ptr<_Tp, _Dp>::reset(std::__ndk1::unique_ptr<_Tp, _Dp>::pointer) [with _Tp = std::__ndk1::__function::__base<void(const mozilla::net::CacheIndexEntry*)>; _Dp = std::__ndk1::__allocator_destructor<std::__ndk1::allocator<std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)> > >; std::__ndk1::unique_ptr<_Tp, _Dp>::pointer = std::__ndk1::__function::__base<void(const mozilla::net::CacheIndexEntry*)>*]':
     0:07.42 /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2598:52:   required from 'std::__ndk1::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = std::__ndk1::__function::__base<void(const mozilla::net::CacheIndexEntry*)>; _Dp = std::__ndk1::__allocator_destructor<std::__ndk1::allocator<std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)> > >]'
     0:07.42 /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/functional:1603:72:   required from 'std::__ndk1::function<_Rp(_ArgTypes ...)>::function(_Fp, typename std::__ndk1::enable_if<(std::__ndk1::function<_Rp(_ArgTypes ...)>::__callable<_Fp>::value && (! std::__ndk1::is_same<_Fp, std::__ndk1::function<_Rp(_ArgTypes ...)> >::value))>::type*) [with _Fp = mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>; _Rp = void; _ArgTypes = {const mozilla::net::CacheIndexEntry*}; typename std::__ndk1::enable_if<(std::__ndk1::function<_Rp(_ArgTypes ...)>::__callable<_Fp>::value && (! std::__ndk1::is_same<_Fp, std::__ndk1::function<_Rp(_ArgTypes ...)> >::value))>::type = void]'
     0:07.42 /srv/mozilla-central/netwerk/cache2/CacheFileContextEvictor.cpp:620:54:   required from here
     0:07.42 /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2630:34: error: invalid conversion from 'std::__ndk1::unique_ptr<std::__ndk1::__function::__base<void(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::__allocator_destructor<std::__ndk1::allocator<std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)> > > >::pointer {aka std::__ndk1::__function::__base<void(const mozilla::net::CacheIndexEntry*)>*}' to 'std::__ndk1::__allocator_destructor<std::__ndk1::allocator<std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)> > >::pointer {aka std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)>*}' [-fpermissive]
     0:07.42              __ptr_.second()(__tmp);
     0:07.42                                   ^
     0:07.42 In file included from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/system_wrappers/memory:3:0,
     0:07.42                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/stl_wrappers/memory:44,
     0:07.42                  from /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/algorithm:628,
     0:07.42                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/system_wrappers/algorithm:3,
     0:07.42                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/stl_wrappers/algorithm:44,
     0:07.43                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/include/mozilla/Span.h:31,
     0:07.43                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/include/nsTArray.h:22,
     0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheIOThread.h:11,
     0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheFileIOManager.h:8,
     0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheFileChunk.h:8,
     0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheFile.h:8,
     0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheEntry.h:9,
     0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheStorage.h:9,
     0:07.43                  from /srv/mozilla-central/netwerk/cache2/AppCacheStorage.h:8,
     0:07.43                  from /srv/mozilla-central/netwerk/cache2/AppCacheStorage.cpp:6,
     0:07.43                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/netwerk/cache2/Unified_cpp_netwerk_cache20.cpp:2:
     0:07.44 /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/memory:3474:10: note: initializing argument 1 of 'void std::__ndk1::__allocator_destructor<_Alloc>::operator()(std::__ndk1::__allocator_destructor<_Alloc>::pointer) [with _Alloc = std::__ndk1::allocator<std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)> >; std::__ndk1::__allocator_destructor<_Alloc>::pointer = std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)>*]'
     0:07.44      void operator()(pointer __p) _NOEXCEPT
     0:07.44           ^
     0:08.21 libxpcom_reflect_xptcall_md_unix.a.desc
     0:08.57 /srv/mozilla-central/config/rules.mk:1060: recipe for target 'Unified_cpp_netwerk_cache20.o' failed
     0:08.57 make[5]: *** [Unified_cpp_netwerk_cache20.o] Error 1
     0:08.57 make[5]: *** Waiting for unfinished jobs....
     0:09.11 libparser_xml.a.desc
     0:09.45 libxpfe_components_directory.a.desc
     0:10.17 libcrmf.a
     0:11.84 /srv/mozilla-central/config/recurse.mk:73: recipe for target 'netwerk/cache2/target' failed
     0:11.84 make[4]: *** [netwerk/cache2/target] Error 2
     0:11.84 make[4]: *** Waiting for unfinished jobs.... 


Submit a correction or amendment below (click here to make a fresh posting)
After submitting an amendment, you'll be able to view the differences between the old and new posts easily.

Syntax highlighting:


To highlight particular lines, prefix each line with ~~
 0:07.40 In file included from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/system_wrappers/memory:3:0,
 0:07.40                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/stl_wrappers/memory:44,
 0:07.40                  from /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/algorithm:628,
 0:07.40                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/system_wrappers/algorithm:3,
 0:07.40                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/stl_wrappers/algorithm:44,
 0:07.40                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/include/mozilla/Span.h:31,
 0:07.41                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/include/nsTArray.h:22,
 0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheIOThread.h:11,
 0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheFileIOManager.h:8,
 0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheFileChunk.h:8,
 0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheFile.h:8,
 0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheEntry.h:9,
 0:07.41                  from /srv/mozilla-central/netwerk/cache2/CacheStorage.h:9,
 0:07.41                  from /srv/mozilla-central/netwerk/cache2/AppCacheStorage.h:8,
 0:07.41                  from /srv/mozilla-central/netwerk/cache2/AppCacheStorage.cpp:6,
 0:07.41                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/netwerk/cache2/Unified_cpp_netwerk_cache20.cpp:2:
 0:07.41 /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/memory: In instantiation of 'void std::__ndk1::unique_ptr<_Tp, _Dp>::reset(std::__ndk1::unique_ptr<_Tp, _Dp>::pointer) [with _Tp = std::__ndk1::__function::__base<void(const mozilla::net::CacheIndexEntry*)>; _Dp = std::__ndk1::__allocator_destructor<std::__ndk1::allocator<std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)> > >; std::__ndk1::unique_ptr<_Tp, _Dp>::pointer = std::__ndk1::__function::__base<void(const mozilla::net::CacheIndexEntry*)>*]':
 0:07.42 /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2598:52:   required from 'std::__ndk1::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = std::__ndk1::__function::__base<void(const mozilla::net::CacheIndexEntry*)>; _Dp = std::__ndk1::__allocator_destructor<std::__ndk1::allocator<std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)> > >]'
 0:07.42 /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/functional:1603:72:   required from 'std::__ndk1::function<_Rp(_ArgTypes ...)>::function(_Fp, typename std::__ndk1::enable_if<(std::__ndk1::function<_Rp(_ArgTypes ...)>::__callable<_Fp>::value && (! std::__ndk1::is_same<_Fp, std::__ndk1::function<_Rp(_ArgTypes ...)> >::value))>::type*) [with _Fp = mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>; _Rp = void; _ArgTypes = {const mozilla::net::CacheIndexEntry*}; typename std::__ndk1::enable_if<(std::__ndk1::function<_Rp(_ArgTypes ...)>::__callable<_Fp>::value && (! std::__ndk1::is_same<_Fp, std::__ndk1::function<_Rp(_ArgTypes ...)> >::value))>::type = void]'
 0:07.42 /srv/mozilla-central/netwerk/cache2/CacheFileContextEvictor.cpp:620:54:   required from here
 0:07.42 /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2630:34: error: invalid conversion from 'std::__ndk1::unique_ptr<std::__ndk1::__function::__base<void(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::__allocator_destructor<std::__ndk1::allocator<std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)> > > >::pointer {aka std::__ndk1::__function::__base<void(const mozilla::net::CacheIndexEntry*)>*}' to 'std::__ndk1::__allocator_destructor<std::__ndk1::allocator<std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)> > >::pointer {aka std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)>*}' [-fpermissive]
 0:07.42              __ptr_.second()(__tmp);
 0:07.42                                   ^
 0:07.42 In file included from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/system_wrappers/memory:3:0,
 0:07.42                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/stl_wrappers/memory:44,
 0:07.42                  from /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/algorithm:628,
 0:07.42                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/system_wrappers/algorithm:3,
 0:07.42                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/stl_wrappers/algorithm:44,
 0:07.43                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/include/mozilla/Span.h:31,
 0:07.43                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/dist/include/nsTArray.h:22,
 0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheIOThread.h:11,
 0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheFileIOManager.h:8,
 0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheFileChunk.h:8,
 0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheFile.h:8,
 0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheEntry.h:9,
 0:07.43                  from /srv/mozilla-central/netwerk/cache2/CacheStorage.h:9,
 0:07.43                  from /srv/mozilla-central/netwerk/cache2/AppCacheStorage.h:8,
 0:07.43                  from /srv/mozilla-central/netwerk/cache2/AppCacheStorage.cpp:6,
 0:07.43                  from /srv/mozilla-central/obj-arm-linux-androideabi-optdebug/netwerk/cache2/Unified_cpp_netwerk_cache20.cpp:2:
 0:07.44 /home/bkelly/.mozbuild/android-ndk-r11c/sources/cxx-stl/llvm-libc++/libcxx/include/memory:3474:10: note: initializing argument 1 of 'void std::__ndk1::__allocator_destructor<_Alloc>::operator()(std::__ndk1::__allocator_destructor<_Alloc>::pointer) [with _Alloc = std::__ndk1::allocator<std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)> >; std::__ndk1::__allocator_destructor<_Alloc>::pointer = std::__ndk1::__function::__func<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)>, std::__ndk1::allocator<mozilla::net::CacheFileContextEvictor::EvictEntries()::<lambda(const mozilla::net::CacheIndexEntry*)> >, void(const mozilla::net::CacheIndexEntry*)>*]'
 0:07.44      void operator()(pointer __p) _NOEXCEPT
 0:07.44           ^
 0:08.21 libxpcom_reflect_xptcall_md_unix.a.desc
 0:08.57 /srv/mozilla-central/config/rules.mk:1060: recipe for target 'Unified_cpp_netwerk_cache20.o' failed
 0:08.57 make[5]: *** [Unified_cpp_netwerk_cache20.o] Error 1
 0:08.57 make[5]: *** Waiting for unfinished jobs....
 0:09.11 libparser_xml.a.desc
 0:09.45 libxpfe_components_directory.a.desc
 0:10.17 libcrmf.a
 0:11.84 /srv/mozilla-central/config/recurse.mk:73: recipe for target 'netwerk/cache2/target' failed
 0:11.84 make[4]: *** [netwerk/cache2/target] Error 2
 0:11.84 make[4]: *** Waiting for unfinished jobs....
Your Name

Remember me
How long should your post be retained?
a day a month forever
Good for IRC or IM conversations
Mozilla systems and collaborative tools are intended for use by the Mozilla community for Mozilla related work and subject to web site terms and conditions at Legal Notices.

Nick Alexander :nalexander [he/him]

Comment 1

•

7 years ago

On IRC, bkelly bisected as far as:

good ffaa07672466
bad  f7adbf457ee20eeffde72694e0d17d73616e3cfd

Ben Kelly [:bkelly, not reviewing]

Reporter

Comment 2

•

7 years ago

good=cb321835e071
bad=c575ecde5303

Ben Kelly [:bkelly, not reviewing]

Reporter

Comment 3

•

7 years ago

good=934ff2cb74b0
bad=c575ecde5303

Something in this push:

https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=c575ecde53030c41c12ba228d8fe78c3ed896e76

Ben Kelly [:bkelly, not reviewing]

Reporter

Comment 4

•

7 years ago

My bisection tells me the error is introduced in:

https://hg.mozilla.org/mozilla-central/rev/9b786cc1d17a

But I have no idea how that is possible and I don't trust the result.

Ben Kelly [:bkelly, not reviewing]

Reporter

Comment 5

•

7 years ago

I have no explanation, but applying rev 9b786cc1d17a breaks the my android debug build per comment 0.

I'm on ubuntu 16.04 LTS.  I updated in case a libc change would help, but it did not

Randall Barker [:rbarker]

Assignee

Comment 6

•

7 years ago

I get the same error on macOS using Android NDK r11b (which I believe is the recommended version).

Botond Ballo [:botond]

Comment 7

•

7 years ago

This is a really weird compiler error. I don't have an explanation either, but I'll post a bit of analysis that might help us get closer to an explanation.

The affected code is using std::function, which in turn uses std::unique_ptr in its implementation. std::unique_ptr can optionally take a custom "deleter" type as its second template argument, and std::function uses such a custom deleter.

The deleter type may define a nested typedef named "pointer", and the one used by std::function does so. std::unique_ptr<T, Deleter> also defines a nested typedef named "pointer", which is computed as follows:

  - if Deleter has a nested typedef named "pointer", it's that
  - otherwise, it's T*

It appears that, on affected systems, the "if Deleter has a nested typedef named 'pointer'" logic goes wrong - the compiler thinks it doesn't, as thus falls back to T*, when it fact it does. This then results in code trying to assign a Deleter::pointer to a T*, triggering the "invalid conversion" error we're seeing.

To check if the Deleter has a nested typedef named "pointer", the unique_ptr implementation uses an internal metafunction called "__has_pointer_type" which checks if a given type has a nested type named "pointer". This metafunction appears to be incorrectly returning "false", but only on some systems (e.g. on Randall's system, but not mine), and only for this particular use of std::function (while others in the codebase are fine). I'm afraid I have no idea why, but it's a possible direction to continue investigating for someone who can reproduce this error.

Ben Kelly [:bkelly, not reviewing]

Reporter

Comment 8

•

7 years ago

Do you have any theory on why it started failing with the rev in comment 5?  I don't see anything that would touch this code or these symbols.

Botond Ballo [:botond]

Comment 9

•

7 years ago

(In reply to Ben Kelly [reviewing, but slowly][:bkelly] from comment #8)
> Do you have any theory on why it started failing with the rev in comment 5? 
> I don't see anything that would touch this code or these symbols.

I agree, that change seems completely unrelated.

I hesistate to jump to conclusions or point the finger at the compiler, but perhaps in this case we're hitting undefined behaviour in the compiler, and that bit of extra code is altering compiler state in a way that triggers it?

John Lin [:jhlin][:jolin]

Comment 10

•

7 years ago

After moving files with errors (in my case, AppCacheStorage.cpp & CacheStorage.cpp) from UNIFIED_SOURCES to SOURCES in netwerk/cache2/moz.build, Fennec builds successfully on my machine (macOS).

Randall Barker [:rbarker]

Assignee

Updated

•

7 years ago

Assignee: nobody → rbarker

Randall Barker [:rbarker]

Assignee

Comment 11

•

7 years ago

Attached patch 0001-Bug-1367798-Fix-Fennec-build-on-some-environments-by-moving-AppCacheStorage.cpp-and-CacheStorage.cpp-from-UNIFIED_SOURCES-to-SOURCES-17060116-650f40aa5d17.patch (obsolete) — Details — Splinter Review

Not sure who can review this.

Randall Barker [:rbarker]

Assignee

Comment 12

•

7 years ago

Attached patch 0001-Bug-1367798-Fix-Fennec-build-on-some-environments-by-moving-AppCacheStorage.cpp-and-CacheStorage.cpp-from-UNIFIED_SOURCES-to-SOURCES-r-froydnj-17060116-a136c219d33f.patch — Details — Splinter Review

Attachment #8873649 - Attachment is obsolete: true

Attachment #8873650 - Flags: review?(nfroyd)

Nathan Froyd [:froydnj]

Comment 13

•

7 years ago

Comment on attachment 8873650 [details] [diff] [review]
0001-Bug-1367798-Fix-Fennec-build-on-some-environments-by-moving-AppCacheStorage.cpp-and-CacheStorage.cpp-from-UNIFIED_SOURCES-to-SOURCES-r-froydnj-17060116-a136c219d33f.patch

Review of attachment 8873650 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, why not?

Attachment #8873650 - Flags: review?(nfroyd) → review+

Randall Barker [:rbarker]

Assignee

Comment 14

•

7 years ago

Try seems to think this patch doesn't break the build:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ba7ac2cc7b90398f948958d7938678c240bd5e7

Pulsebot

Comment 15

•

7 years ago

Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0e6bf9a86db
Fix Fennec build on some environments by moving AppCacheStorage.cpp and CacheStorage.cpp from UNIFIED_SOURCES to SOURCES r=froydnj

Carsten Book [:Tomcat]

Comment 16

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/e0e6bf9a86db

Status: NEW → RESOLVED

Closed: 7 years ago

status-firefox55: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 55

Andrew McCreight [:mccr8]

Updated

•

7 years ago

Updated

•

5 years ago

Product: Firefox for Android → Firefox Build System

Target Milestone: Firefox 55 → mozilla55

0001-Bug-1367798-Fix-Fennec-build-on-some-environments-by-moving-AppCacheStorage.cpp-and-CacheStorage.cpp-from-UNIFIED_SOURCES-to-SOURCES-17060116-650f40aa5d17.patch 7 years ago Randall Barker [:rbarker] 1.28 KB, patch		Details \| Diff \| Splinter Review
0001-Bug-1367798-Fix-Fennec-build-on-some-environments-by-moving-AppCacheStorage.cpp-and-CacheStorage.cpp-from-UNIFIED_SOURCES-to-SOURCES-r-froydnj-17060116-a136c219d33f.patch 7 years ago Randall Barker [:rbarker] 1.29 KB, patch	froydnj : review+	Details \| Diff \| Splinter Review