hidden extension updates show up in about:addons if open during update

NEW
Assigned to

Status

()

a year ago
7 months ago

People

(Reporter: rhelmer, Assigned: rhelmer)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: triaged)

Attachments

(2 attachments)

(Assignee)

Description

a year ago
If about:addons is open when a background update happens, any hotfix or system add-on updates found show up. On refresh they go away.

System add-on updates are never uninstallable or user-disableable so there isn't a danger of users accidentally removing something important.
(Assignee)

Comment 1

a year ago
I suspect the issue here is there is an install listener that isn't checking to see that an add-on is hidden.

The fact that this happens to hotfix too makes me think this is probably an old bug and so was overlooked for system add-on updates too.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Duplicate of this bug: 1367559

Comment 4

a year ago
mozreview-review
Comment on attachment 8871348 [details]
Bug 1367800 - do not display hidden add-ons in about:addons during upgrades.

https://reviewboard.mozilla.org/r/142826/#review147138

I think we should also check if the add-on is hidden before adding the item, so they don't briefly show up during the download/install and then mysteriously disappear. r=me with that.
Attachment #8871348 - Flags: review+
(Assignee)

Comment 5

a year ago
aswan points out that we do have browser tests for ensuring that hidden add-ons don't appear in the UI, so I will add some tests now (was going to defer it to a followup, when I thought we didn't have test coverage for this).

Updated

a year ago
Whiteboard: triaged
(Assignee)

Updated

a year ago
Attachment #8871348 - Flags: review?(aswan)

Comment 6

a year ago
Created attachment 8874399 [details]
System add-ons visible in the Add-ons Manager

As I’ve said in the duplicate bug 1367559 comment 2, I’ve previously not had a screenshot of system add-ons in the Add-ons Manager.

After a recent system add-ons update, I finally got a screenshot of system add-ons in the Add-ons Manager, so I’m posting it here, because bug 1367559 is a duplicate of this bug.
(Assignee)

Updated

7 months ago
Summary: hotfix and system add-on updates show up in about:addons if open during update → system add-on updates show up in about:addons if open during update
(Assignee)

Updated

7 months ago
Duplicate of this bug: 1451618
(Assignee)

Updated

7 months ago
Summary: system add-on updates show up in about:addons if open during update → hidden extension updates show up in about:addons if open during update
You need to log in before you can comment on or make changes to this bug.