1367800 - hidden extension updates show up in about:addons if open during update

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Robert Helmer [:rhelmer]]

If about:addons is open when a background update happens, any hotfix or system add-on updates found show up. On refresh they go away.

System add-on updates are never uninstallable or user-disableable so there isn't a danger of users accidentally removing something important.

Comment 1

[Robert Helmer [:rhelmer]]

I suspect the issue here is there is an install listener that isn't checking to see that an add-on is hidden.

The fact that this happens to hotfix too makes me think this is probably an old bug and so was overlooked for system add-on updates too.

Comment 2

[Robert Helmer [:rhelmer]]

Attachment: Bug 1367800 - do not display hidden add-ons in about:addons during upgrades.

Review commit: https://reviewboard.mozilla.org/r/142826/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142826/

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8871348 [details]
Bug 1367800 - do not display hidden add-ons in about:addons during upgrades.

https://reviewboard.mozilla.org/r/142826/#review147138

I think we should also check if the add-on is hidden before adding the item, so they don't briefly show up during the download/install and then mysteriously disappear. r=me with that.

Comment 5

[Robert Helmer [:rhelmer]]

aswan points out that we do have browser tests for ensuring that hidden add-ons don't appear in the UI, so I will add some tests now (was going to defer it to a followup, when I thought we didn't have test coverage for this).

Comment 6

[ExE Boss]

Attachment: System add-ons visible in the Add-ons Manager

As I’ve said in the duplicate bug 1367559 comment 2, I’ve previously not had a screenshot of system add-ons in the Add-ons Manager.

After a recent system add-ons update, I finally got a screenshot of system add-ons in the Add-ons Manager, so I’m posting it here, because bug 1367559 is a duplicate of this bug.

Comment 8

[David Durst [:ddurst]]

Let's land this! (paraphrasing kmaglione)

Comment 9

[Robert Helmer [:rhelmer]]

Attachment: Bug 1367800 - do not display hidden add-ons in about:addons during upgrades. r?kmag

Comment 10

[Robert Helmer [:rhelmer]]

I tested this manually (reused the system add-on test set up in bug 1428459 comment 14) and I can reproduce this behavior by just leaving the add-ons manager open while add-on updates are running. The updates are hidden with the latest patch.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e80210429422f8aaafca1c5c36deaa5cff142387&selectedJob=223366973

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bce1b588653a
do not display hidden add-ons in about:addons during upgrades. r=kmag

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/bce1b588653a

Comment 13

[Victor Carciu]

Verified as fixed on Windows 10x64 and macOS 10.13.6 using https://treeherder.mozilla.org/#/jobs?repo=try&revision=e80210429422f8aaafca1c5c36deaa5cff142387&selectedJob=223366973 .

I can confirm that I reproduced the bug on previous versions.

I will attach a postfix screenshot.

Comment 14

[Victor Carciu]

Attachment: Before\after screenshot