Closed Bug 1367837 Opened 3 years ago Closed 3 years ago

Make QR tests not crash with APZ enabled

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(3 files)

Right now if APZ is enabled in webrender (by commenting out [1]) and the reftests are run, they fail for reasons unrelated to correctness. Specifically, APIs like DOMWindowUtils.setAsyncScrollOffset are not implemented with webrender. We should make those work with webrender, so that the tests fail for correctness reasons.

[1] http://searchfox.org/mozilla-central/rev/35b37316149108d53a02fb8498e250ea8a22ab5d/widget/nsBaseWidget.cpp#1262
^ many failures, but they're all correctness. So I think I can land the patches (but keep APZ disabled).
Comment on attachment 8871396 [details]
Bug 1367837 - Expose a testing helper method to get an APZC instance from the layers id and scroll id.

https://reviewboard.mozilla.org/r/142876/#review147004
Attachment #8871396 - Flags: review?(botond) → review+
Comment on attachment 8871397 [details]
Bug 1367837 - Implement some APZ test util APIs for webrender.

https://reviewboard.mozilla.org/r/142878/#review147016
Attachment #8871397 - Flags: review?(botond) → review+
Comment on attachment 8871395 [details]
Bug 1367837 - Have the CompositorBridgeParent::FlushApzRepaints function take a layers id instead of a layer tree.

https://reviewboard.mozilla.org/r/142874/#review147134
Attachment #8871395 - Flags: review?(dvander) → review+
Comment on attachment 8871397 [details]
Bug 1367837 - Implement some APZ test util APIs for webrender.

https://reviewboard.mozilla.org/r/142878/#review147326
Attachment #8871397 - Flags: review?(dvander) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/b657891b5b02
Have the CompositorBridgeParent::FlushApzRepaints function take a layers id instead of a layer tree. r=dvander
https://hg.mozilla.org/projects/graphics/rev/db86dd808a1a
Expose a testing helper method to get an APZC instance from the layers id and scroll id. r=botond
https://hg.mozilla.org/projects/graphics/rev/9c246299ad82
Implement some APZ test util APIs for webrender. r=botond,dvander
Depends on: 1369079
No longer depends on: 1369079
Depends on: 1375897
You need to log in before you can comment on or make changes to this bug.