1367837 - Make QR tests not crash with APZ enabled

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Right now if APZ is enabled in webrender (by commenting out [1]) and the reftests are run, they fail for reasons unrelated to correctness. Specifically, APIs like DOMWindowUtils.setAsyncScrollOffset are not implemented with webrender. We should make those work with webrender, so that the tests fail for correctness reasons.

[1] http://searchfox.org/mozilla-central/rev/35b37316149108d53a02fb8498e250ea8a22ab5d/widget/nsBaseWidget.cpp#1262

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=88dd3e8d7ff18be6cf8aa3dd9606f64e889a2b37

Comment 2

[Kartikaya Gupta (email:[e-mail])]

^ many failures, but they're all correctness. So I think I can land the patches (but keep APZ disabled).

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1367837 - Have the CompositorBridgeParent::FlushApzRepaints function take a layers id instead of a layer tree.

This is helpful for reusing the FlushApzRepaints from
WebRenderBridgeParent, since it no longer assumes there's a layers
transaction object.

Review commit: https://reviewboard.mozilla.org/r/142874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142874/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1367837 - Expose a testing helper method to get an APZC instance from the layers id and scroll id.

Review commit: https://reviewboard.mozilla.org/r/142876/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142876/

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1367837 - Implement some APZ test util APIs for webrender.

This implements some methods exposed on DOMWindowUtils and used by
reftests, for the WebRender codepath. The implementation is very similar
to the implementation in LayerTransactionParent.

Review commit: https://reviewboard.mozilla.org/r/142878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142878/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8871395 [details]
Bug 1367837 - Have the CompositorBridgeParent::FlushApzRepaints function take a layers id instead of a layer tree.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142874/diff/1-2/

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8871396 [details]
Bug 1367837 - Expose a testing helper method to get an APZC instance from the layers id and scroll id.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142876/diff/1-2/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8871397 [details]
Bug 1367837 - Implement some APZ test util APIs for webrender.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142878/diff/1-2/

Comment 9

[Botond Ballo [:botond]]

Comment on attachment 8871396 [details]
Bug 1367837 - Expose a testing helper method to get an APZC instance from the layers id and scroll id.

https://reviewboard.mozilla.org/r/142876/#review147004

Comment 10

[Botond Ballo [:botond]]

Comment on attachment 8871397 [details]
Bug 1367837 - Implement some APZ test util APIs for webrender.

https://reviewboard.mozilla.org/r/142878/#review147016

Comment 11

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8871395 [details]
Bug 1367837 - Have the CompositorBridgeParent::FlushApzRepaints function take a layers id instead of a layer tree.

https://reviewboard.mozilla.org/r/142874/#review147134

Comment 12

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8871397 [details]
Bug 1367837 - Implement some APZ test util APIs for webrender.

https://reviewboard.mozilla.org/r/142878/#review147326

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/b657891b5b02
Have the CompositorBridgeParent::FlushApzRepaints function take a layers id instead of a layer tree. r=dvander
https://hg.mozilla.org/projects/graphics/rev/db86dd808a1a
Expose a testing helper method to get an APZC instance from the layers id and scroll id. r=botond
https://hg.mozilla.org/projects/graphics/rev/9c246299ad82
Implement some APZ test util APIs for webrender. r=botond,dvander

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b657891b5b02
https://hg.mozilla.org/mozilla-central/rev/db86dd808a1a
https://hg.mozilla.org/mozilla-central/rev/9c246299ad82